From nobody Sun Dec 17 21:31:39 2023
X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4StbkV3RJDz54HrJ;
	Sun, 17 Dec 2023 21:31:46 +0000 (UTC)
	(envelope-from glebius@freebsd.org)
Received: from glebi.us (glebi.us [162.251.186.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 4StbkV0G44z3RgF;
	Sun, 17 Dec 2023 21:31:45 +0000 (UTC)
	(envelope-from glebius@freebsd.org)
Authentication-Results: mx1.freebsd.org;
	none
Received: by glebi.us (Postfix, from userid 1000)
	id 6DC043317D; Sun, 17 Dec 2023 13:31:39 -0800 (PST)
Date: Sun, 17 Dec 2023 13:31:39 -0800
From: Gleb Smirnoff <glebius@freebsd.org>
To: Gordon Bergling <gbe@freebsd.org>
Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org,
	dev-commits-src-main@freebsd.org
Subject: Re: git: 4fb5eda6493c - main - tcp: Remove the documented dependency
 of TCPHPTS for RACK and BBR
Message-ID: <ZX9ouwGiIrBjUBC5@FreeBSD.org>
References: <202312171831.3BHIVgjE004377@gitrepo.freebsd.org>
List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all
List-Help: <mailto:dev-commits-src-all+help@freebsd.org>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-all+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-all@freebsd.org
X-BeenThere: dev-commits-src-all@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202312171831.3BHIVgjE004377@gitrepo.freebsd.org>
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]
X-Spamd-Bar: ----
X-Rspamd-Queue-Id: 4StbkV0G44z3RgF

On Sun, Dec 17, 2023 at 06:31:42PM +0000, Gordon Bergling wrote:
G> commit 4fb5eda6493c3dada695efbfad0a44d204b7fc5e
G> Author:     Gordon Bergling <gbe@FreeBSD.org>
G> AuthorDate: 2023-12-17 18:31:16 +0000
G> Commit:     Gordon Bergling <gbe@FreeBSD.org>
G> CommitDate: 2023-12-17 18:31:16 +0000
G> 
G>     tcp: Remove the documented dependency of TCPHPTS for RACK and BBR
G>     
G>     Since TCPHPTS is now included in the GENERIC kernel, remove the
G>     documented dependency of it from the tcp_rack(4) and tcp_bbr(4)
G>     manual pages.

The change is correct, but commit message is wrong. The options is not
included into GENERIC, neither presence of an option in GENERIC 
justifies removal of SYNOPSIS entry.

The correct reason for SYNOPSIS entry removal is that HPTS is now a
loadable module.

-- 
Gleb Smirnoff