From owner-freebsd-current@FreeBSD.ORG Sat Aug 10 20:12:03 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 29F43964 for ; Sat, 10 Aug 2013 20:12:03 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from thebighonker.lerctr.org (lrosenman-1-pt.tunnel.tserv8.dal1.ipv6.he.net [IPv6:2001:470:1f0e:3ad::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E8B352E58 for ; Sat, 10 Aug 2013 20:12:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=lerami; h=Message-ID:References:In-Reply-To:Subject:To:From:Date:Content-Transfer-Encoding:Content-Type:MIME-Version; bh=lUvVFh4J0dtUaCu0MM2d7N1Or4Yb+FwRWAKfOAfMO3M=; b=T64imEWbelyRaYA6CycaC81tKVrGPbYNVPzO1R9u9ereHRfyAGRjv7o2sjhA0ID2dS7CSOPnWNVc7RJiXvmd2pMWVLWEj9KgKxQ++XMB5Dks9zWhZ4F5KRffvMcX1xdfvQGAmm7WrZIH6WtvF7jYHy0yFo+hR7QZ7/QTlk/MZ2w=; Received: from localhost.lerctr.org ([127.0.0.1]:14312 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtpa (Exim 4.80.1 (FreeBSD)) (envelope-from ) id 1V8FW4-000NX2-Ep for freebsd-current@freebsd.org; Sat, 10 Aug 2013 15:12:01 -0500 Received: from cpe-72-182-93-216.austin.res.rr.com ([72.182.93.216]) by webmail.lerctr.org with HTTP (HTTP/1.1 POST); Sat, 10 Aug 2013 15:11:59 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 10 Aug 2013 15:11:59 -0500 From: Larry Rosenman To: freebsd-current@freebsd.org Subject: Re: crash with cpucontrol/microcode update : Today's -CURRENT In-Reply-To: <20130810200256.GI4972@kib.kiev.ua> References: <20130810200256.GI4972@kib.kiev.ua> Message-ID: X-Sender: ler@lerctr.org User-Agent: Roundcube Webmail/0.9.2 X-Spam-Score: -2.9 (--) X-LERCTR-Spam-Score: -2.9 (--) X-Spam-Report: SpamScore (-2.9/5.0) ALL_TRUSTED=-1, BAYES_00=-1.9, RP_MATCHES_RCVD=-0.001 X-LERCTR-Spam-Report: SpamScore (-2.9/5.0) ALL_TRUSTED=-1, BAYES_00=-1.9, RP_MATCHES_RCVD=-0.001 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Aug 2013 20:12:03 -0000 On 2013-08-10 15:02, Konstantin Belousov wrote: > Try this. > > diff --git a/sys/dev/cpuctl/cpuctl.c b/sys/dev/cpuctl/cpuctl.c > index 742ef0db..4e5abb2 100644 > --- a/sys/dev/cpuctl/cpuctl.c > +++ b/sys/dev/cpuctl/cpuctl.c > @@ -346,8 +346,7 @@ update_intel(int cpu, cpuctl_update_args_t *args, > struct thread *td) > else > ret = EEXIST; > fail: > - if (ptr != NULL) > - contigfree(ptr, args->size, M_CPUCTL); > + free(ptr, M_CPUCTL); > return (ret); > } > > @@ -476,8 +475,7 @@ update_via(int cpu, cpuctl_update_args_t *args, > struct thread *td) > else > ret = 0; > fail: > - if (ptr != NULL) > - contigfree(ptr, args->size, M_CPUCTL); > + free(ptr, M_CPUCTL); > return (ret); > } Fixed it. # service microcode_update onestart Updating cpucodes... /usr/local/share/cpucontrol/m401067660F.fw: updating cpu /dev/cpuctl0 from rev 0x60c to rev 0x60f... done. /usr/local/share/cpucontrol/m401067660F.fw: updating cpu /dev/cpuctl1 from rev 0x60c to rev 0x60f... done. /usr/local/share/cpucontrol/m401067660F.fw: updating cpu /dev/cpuctl2 from rev 0x60c to rev 0x60f... done. /usr/local/share/cpucontrol/m401067660F.fw: updating cpu /dev/cpuctl3 from rev 0x60c to rev 0x60f... done. /usr/local/share/cpucontrol/m401067660F.fw: updating cpu /dev/cpuctl4 from rev 0x60c to rev 0x60f... done. /usr/local/share/cpucontrol/m401067660F.fw: updating cpu /dev/cpuctl5 from rev 0x60c to rev 0x60f... done. /usr/local/share/cpucontrol/m401067660F.fw: updating cpu /dev/cpuctl6 from rev 0x60c to rev 0x60f... done. /usr/local/share/cpucontrol/m401067660F.fw: updating cpu /dev/cpuctl7 from rev 0x60c to rev 0x60f... done. Done. # ^D$ -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 (c) E-Mail: ler@lerctr.org US Mail: 108 Turvey Cove, Hutto, TX 78634-5688