From owner-svn-src-head@FreeBSD.ORG Thu Oct 23 22:47:28 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 927DCAEC; Thu, 23 Oct 2014 22:47:28 +0000 (UTC) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 55FB8D26; Thu, 23 Oct 2014 22:47:28 +0000 (UTC) Received: from nine.des.no (smtp.des.no [194.63.250.102]) by smtp-int.des.no (Postfix) with ESMTP id 41001A205; Thu, 23 Oct 2014 22:47:27 +0000 (UTC) Received: by nine.des.no (Postfix, from userid 1001) id 58563102C3; Fri, 24 Oct 2014 00:47:16 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Xin LI Subject: Re: svn commit: r273552 - head/sys/kern References: <201410231823.s9NINpXD082633@svn.freebsd.org> Date: Fri, 24 Oct 2014 00:47:16 +0200 In-Reply-To: <201410231823.s9NINpXD082633@svn.freebsd.org> (Xin LI's message of "Thu, 23 Oct 2014 18:23:51 +0000 (UTC)") Message-ID: <86egtyz9mz.fsf@nine.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Oct 2014 22:47:28 -0000 Xin LI writes: > Log: > Test if 'env' is NULL before doing memset() and strlen(), > the caller may pass NULL to freeenv(). If this is in response to a panic in early boot, the real bug is elsewhere (see r273564). Adding a NULL check here only hides it. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no