From owner-svn-src-head@freebsd.org Sat Aug 12 16:16:38 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 528A1DE0127; Sat, 12 Aug 2017 16:16:38 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-pg0-f51.google.com (mail-pg0-f51.google.com [74.125.83.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2D6E966BE3; Sat, 12 Aug 2017 16:16:37 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-pg0-f51.google.com with SMTP id l64so26213210pge.5; Sat, 12 Aug 2017 09:16:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=HwktBXzSMQLFrKNqzfmXGAr/jt9+iFq0lg2sXAmuRqQ=; b=TR961h7XHbZVlZVytk8t8sLEokAtEP/7Qf/WuJ6n/7nYoThlT0NSKqehQhk7kZgMWq 8gcTaQdBoVkPvXDXZGZY8UvWVOy4+32uSBqwtZFNEPOHJuERyK6VittRa4DCbUnQIDb1 kdLR82u2lU27HE8P5n5hXfwW7S7djp4ccwC490rN/v8eQzJTDI3WXnwy+MyyAceE8OtG CBA/LruWomQXp4pNEAwjdpi4noYI32zM+MMhVtpzTMSj+5cKQ8iSKAVf9DW7ciOp0vdv cNaf0xwqZJg29A/S5AEiylb/wfCTMyz/mETvd8OBMhY0f3cqIHExyJ1WKki0c8QVxJLA TJLg== X-Gm-Message-State: AHYfb5gKyg9wl9vZcFcvTH5NePr1KDwl3EL6uFIDft/V57gOvfstqilS tbA2ohBZSyT7ByvB14g= X-Received: by 10.99.175.1 with SMTP id w1mr18442935pge.392.1502554596955; Sat, 12 Aug 2017 09:16:36 -0700 (PDT) Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com. [209.85.192.176]) by smtp.gmail.com with ESMTPSA id b4sm6517025pfg.132.2017.08.12.09.16.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Aug 2017 09:16:36 -0700 (PDT) Received: by mail-pf0-f176.google.com with SMTP id h68so26873173pfk.0; Sat, 12 Aug 2017 09:16:36 -0700 (PDT) X-Received: by 10.98.70.200 with SMTP id o69mr19948077pfi.325.1502554596638; Sat, 12 Aug 2017 09:16:36 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.100.150.15 with HTTP; Sat, 12 Aug 2017 09:16:36 -0700 (PDT) In-Reply-To: <201708121518.v7CFIHld035164@repo.freebsd.org> References: <201708121518.v7CFIHld035164@repo.freebsd.org> From: Conrad Meyer Date: Sat, 12 Aug 2017 09:16:36 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r322427 - in head/lib/libc: stdlib string tests/string To: Konstantin Belousov Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Aug 2017 16:16:38 -0000 On Sat, Aug 12, 2017 at 8:18 AM, Konstantin Belousov wrote: > Author: kib > Date: Sat Aug 12 15:18:17 2017 > New Revision: 322427 > URL: https://svnweb.freebsd.org/changeset/base/322427 > > Log: > Improve standard compliance for memset_s() and abort_handler_s(). > > abort_handler_s() currently simply calls abort(), though the standard > specifies more: "Writes an implementation-defined message to stderr > which must include the string pointed to by msg and calls abort()." > > memset_s() is missing error condition "n > smax", and does not invoke > the constraint handler after filling the buffer: "following errors are > detected at runtime and call the currently installed constraint > handler function after storing ch in every location of the destination > range [dest, dest+destsz) if dest and destsz are themselves valid", > one of the errors is "n > smax" itself. > > Submitted by: Yuri Pankov > MFC after: 1 week > Differential revision: https://reviews.freebsd.org/D11991 PR: 221323