From owner-svn-ports-all@FreeBSD.ORG Mon Nov 4 14:21:18 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0280335C for ; Mon, 4 Nov 2013 14:21:18 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-qc0-x22b.google.com (mail-qc0-x22b.google.com [IPv6:2607:f8b0:400d:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B1749284E for ; Mon, 4 Nov 2013 14:21:17 +0000 (UTC) Received: by mail-qc0-f171.google.com with SMTP id i7so3914382qcq.16 for ; Mon, 04 Nov 2013 06:21:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=ekqXoWVGJibr0LKTsywgIe1tiij6OdmIGvATE5xBeYQ=; b=aRe3d00MZQOvQIBNvdZT9zdYIiykPCBgtVnNAaykqlHZKvvsiwlIfooPDk11s9vF9S rXL1v5jOgtADWYzKv3QcNBzy4ltQo4IieORDFUTCehbUMsHYtk4moGsvZxVe043ju9v9 veY6uoEQgeclqtMlzdXDfEpjjGsosVs5gjflk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=ekqXoWVGJibr0LKTsywgIe1tiij6OdmIGvATE5xBeYQ=; b=E3LnAEaKtbT++qTH+z4EIiq7TS5siAAO4jBwVRBAb2rHN+pA0HdOpdCDSBrs3jAf9U TcmhL8GjGxBvkm47iZm8uAcAMKlXDRFcusMeIvjsAbaxmLDtpRMLZzvd2qmin70O95Ae biQPmXmyDmn2ZN8XhVBieDV3DY0qKqsxSIdJq/GF6oD+2OA/LedSYYiT6jBY5sRwGnTL i0Avrt9Qcw0H6ewx7dKnP0O+NDhAW930FkL7rIK/hv8EtRvOicqwTFNwqCFw9pTKW/4p G9M6UV1AbW9f+7Et+/54EtNm+YWiksJkVFQsRJUpiqSVpQMdr7dmXN+DywjGkwgVj3zZ g5Ng== X-Gm-Message-State: ALoCoQmWt6X/3i5LInJGN1SU2mmfEzG1BIXtRyPTerG1TAOrD5a6LhqBNZR4a0FP9zh0jkDZVX6R X-Received: by 10.49.62.3 with SMTP id u3mr22098325qer.6.1383574876906; Mon, 04 Nov 2013 06:21:16 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.96.63.101 with HTTP; Mon, 4 Nov 2013 06:20:46 -0800 (PST) In-Reply-To: <1383574552.17263.42707017.6BE762CA@webmail.messagingengine.com> References: <201311030036.rA30aXLv016213@svn.freebsd.org> <20131103201410.2f95dc09@kalimero.tijl.coosemans.org> <1383574552.17263.42707017.6BE762CA@webmail.messagingengine.com> From: Eitan Adler Date: Mon, 4 Nov 2013 09:20:46 -0500 X-Google-Sender-Auth: wPXTbiwl2nGdDy11C_shKFYgyAc Message-ID: Subject: Re: svn commit: r332567 - head/graphics/apvlv To: Mark Felder Content-Type: text/plain; charset=UTF-8 Cc: "svn-ports-head@freebsd.org" , Tijl Coosemans , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Nov 2013 14:21:18 -0000 On Mon, Nov 4, 2013 at 9:15 AM, Mark Felder wrote: > > > On Sun, Nov 3, 2013, at 13:38, Eitan Adler wrote: >> On Sun, Nov 3, 2013 at 2:14 PM, Tijl Coosemans wrote: >> >> > but now PTHREAD_CFLAGS is always empty >> >> Which is always a mistake. PTHREAD_CFLAGS should be replaced with >> -pthread >> >> so you can remove that line and PTHREAD_LIBS is always >> > -pthread. >> >> As should this. >> > > Thanks for the feedback guys. Perhaps we should put PTHREAD_CFLAGS and > PTHREAD_LIBS into portlint as well. > > I'm not 100% sure I understand the changes you're proposing -- I'm > getting caught up on the wording. Is this diff what you're suggesting? Yes. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams