From owner-freebsd-smp Tue Apr 25 8:10:22 2000 Delivered-To: freebsd-smp@freebsd.org Received: from Ilsa.StevesCafe.com (Ilsa.StevesCafe.com [206.168.13.65]) by hub.freebsd.org (Postfix) with ESMTP id 138FB37BD3B for ; Tue, 25 Apr 2000 08:10:20 -0700 (PDT) (envelope-from smp@Ilsa.StevesCafe.com) Received: from Ilsa.StevesCafe.com (localhost [127.0.0.1]) by Ilsa.StevesCafe.com (8.9.3/8.9.3) with ESMTP id JAA10136; Tue, 25 Apr 2000 09:09:59 -0600 (MDT) (envelope-from smp@Ilsa.StevesCafe.com) Message-Id: <200004251509.JAA10136@Ilsa.StevesCafe.com> X-Mailer: exmh version 2.0.2 2/24/98 From: Steve Passe To: Luoqi Chen Cc: sthaug@nethelp.no, freebsd-smp@FreeBSD.ORG, mihara@prd.fc.nec.co.jp Subject: Re: Multiple APIC support (RE: Issues with Spankin' new Poweredge 4400 w/ dual 866's and 133MHz FSB?) In-reply-to: Your message of "Tue, 25 Apr 2000 07:55:00 EDT." <200004251155.e3PBt0D19565@lor.watermarkgroup.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 25 Apr 2000 09:09:59 -0600 Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > > The pmap.c code looks somewhat different in 3.4-STABLE, and it wasn't > > obvious to me what the complete patch for 3.4-STABLE would be. > > > The fix for non-page-aligned ioapic is to add the offset within the page > to get the mapped ioapic address. For 3.4-STABLE, it would be > ioapic[i] = (ioapic_t *)&SMP_ioapic[j * PAGE_SIZE > + (io_apic_addres[0] & PAGE_MASK)]; ^^^ I don't have 3.4 code handy to see the outer loop, but didn't the const 0 go away here? > I don't have any machine myself to test it with, so if you can confirm > it won't break anything on your machine, I would MFC the fix to 3.4-STABLE. -- Steve Passe | powered by smp@csn.net | Symmetric MultiProcessor FreeBSD To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message