From owner-svn-src-all@FreeBSD.ORG Thu Aug 12 17:35:16 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with ESMTP id DD4B8106564A; Thu, 12 Aug 2010 17:35:15 +0000 (UTC) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: mdf@FreeBSD.org Date: Thu, 12 Aug 2010 13:34:57 -0400 User-Agent: KMail/1.6.2 References: <201008121613.o7CGDOij028986@svn.freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <201008121335.05300.jkim@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r211228 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Aug 2010 17:35:16 -0000 On Thursday 12 August 2010 12:37 pm, mdf@FreeBSD.org wrote: > On Thu, Aug 12, 2010 at 9:13 AM, Jung-uk Kim wrote: > > Author: jkim > > Date: Thu Aug 12 16:13:24 2010 > > New Revision: 211228 > > URL: http://svn.freebsd.org/changeset/base/211228 > > > > Log: > >  Provide description for 'machdep.disable_rtc_set' sysctl. > >  Clean up style(9)  nits.  Remove a redundant return statement > > and an unnecessary variable. --- >8 SNIP!!! --- >8 --- > While the device_printf() is a single statement, it spans multiple > lines. It seems in this instance that clarity is preserved better > by using braces even though not required by C. > > Quoting style(9): > > Space after keywords (if, while, for, return, switch). No braces > ('{' and '}') are used for control statements with zero or only a > single statement unless that statement is more than a single line > in which case they are permitted. > > So both styles are accepted, and I would think that changing this > is needless code churn. Some times it is very hard to read code when if statements contain excessive braces and 'else' statements although is permitted by style(9). It was one of those cases. Please note a 'else' block was also removed from there. Besides, I don't think it is revert worthy, either. ;-) Thanks, Jung-uk Kim