From owner-freebsd-commit  Sun Sep 24 10:37:38 1995
Return-Path: owner-commit
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id KAA06609
          for freebsd-commit-outgoing; Sun, 24 Sep 1995 10:37:38 -0700
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id KAA06595
          for cvs-all-outgoing; Sun, 24 Sep 1995 10:37:35 -0700
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id KAA06585
          for cvs-gnu-outgoing; Sun, 24 Sep 1995 10:37:34 -0700
Received: from irbs.irbs.com (irbs.com [199.182.75.129])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id KAA06574
          ; Sun, 24 Sep 1995 10:37:28 -0700
Received: (from jc@localhost) by irbs.irbs.com (8.6.12/8.6.6) id NAA03705; Sun, 24 Sep 1995 13:37:23 -0400
From: John Capo <jc@irbs.com>
Message-Id: <199509241737.NAA03705@irbs.irbs.com>
Subject: Re: cvs commit: src/gnu/usr.sbin/ypserv server.c
To: phk@critter.tfs.com (Poul-Henning Kamp)
Date: Sun, 24 Sep 1995 13:37:22 -0400 (EDT)
Cc: wpaul@freebsd.org, CVS-commiters@freebsd.org, cvs-gnu@freebsd.org
In-Reply-To: <170.811963760@critter.tfs.com> from "Poul-Henning Kamp" at Sep 24, 95 10:29:20 am
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 961       
Sender: owner-commit@freebsd.org
Precedence: bulk

Poul-Henning Kamp writes:
> 
> > wpaul       95/09/24 10:21:53
> > 
> >   Modified:    gnu/usr.sbin/ypserv  server.c
> >   Log:
> >   phkmalloc strikes!
> >   
> >   [...]
> >   
> >   Note that with the original malloc(), there were never any errors
> >   flagged. phkmalloc complained quite loudly.
> 
> Hmm, what was the exact complaint ?  that something got freed twice ?
> 
> It is not a big deal to ignore this in phkmalloc, but I though it was
> a bad idea to let it slip.
> 

There are a bunch of bogus frees in ypserv.  I linked it with
gnumalloc a few months back and discovered that ypserv is freeing
the result of db calls.  The pointers returned point within db
objects.  phkmalloc cores in this case.

I believe I filed a GNATS report when I first discovered this months
ago.  I know I posted it to -current.

There are other cases where ypserv frees already freed memory.
The phkmalloc warnings are a Good Thing(tm).

John Capo
IRBS Engineering