From owner-freebsd-gnome@freebsd.org Wed Nov 9 20:58:35 2016 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3F3FC38AD6 for ; Wed, 9 Nov 2016 20:58:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 9CE27CFD for ; Wed, 9 Nov 2016 20:58:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 9C3BCC38AD5; Wed, 9 Nov 2016 20:58:35 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9BE3AC38AD4 for ; Wed, 9 Nov 2016 20:58:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7172BCFC for ; Wed, 9 Nov 2016 20:58:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uA9KwXVL077995 for ; Wed, 9 Nov 2016 20:58:35 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 211684] audio/pulseaudio: Respect hw.snd.default_unit Date: Wed, 09 Nov 2016 20:58:34 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: flagtypes.name attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2016 20:58:35 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211684 lightside changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176143|maintainer-approval?(gnome@ | Flags|FreeBSD.org) | Attachment #176143|0 |1 is obsolete| | Attachment #176830| |maintainer-approval?(gnome@ Flags| |FreeBSD.org) --- Comment #18 from lightside --- Created attachment 176830 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D176830&action= =3Dedit Proposed patch (since 424621 revision) (In reply to comment #17) > Default device parsing fails with hw.snd.verbose > 0. Not sure what you meant about "parsing fails". The parsing algorithm was developed in such a way, that recognizes concrete format of /dev/sndstat ou= tput (e.g. the "default" word at the end of line). If format of output is differ= ent, then further algorithm does nothing (as it was for "hw.snd.verbose > 0" cas= e). Theoretically possible to break parsing algorithm (e.g. with custom /dev/sndstat output), I guess. But this is a possible drawback of such approach. Probably, you meant, that "the parsing algorithm doesn't work for hw.snd.verbose > 0 case". Looks like, sysctl hw.snd.verbose may change form= at of /dev/sndstat output. I extended parsing algorithm for "hw.snd.verbose > = 0" case. Thanks for review. --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=