From owner-svn-src-head@FreeBSD.ORG Sat Dec 6 15:16:00 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 66611596; Sat, 6 Dec 2014 15:16:00 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1FF32D1D; Sat, 6 Dec 2014 15:15:59 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::45a3:ddb8:2175:f9c7] (unknown [IPv6:2001:7b8:3a7:0:45a3:ddb8:2175:f9c7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 734AEB80A; Sat, 6 Dec 2014 16:15:57 +0100 (CET) Subject: Re: svn commit: r275564 - head/sys/arm/arm Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: multipart/signed; boundary="Apple-Mail=_5BADA196-0D36-4A71-AC60-586F132A6051"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b3 From: Dimitry Andric In-Reply-To: <201412061159.sB6BxZOV054978@svn.freebsd.org> Date: Sat, 6 Dec 2014 16:15:55 +0100 Message-Id: <078F2487-9D4D-435C-92CC-C0E3EC7A34AE@FreeBSD.org> References: <201412061159.sB6BxZOV054978@svn.freebsd.org> To: Andrew Turner X-Mailer: Apple Mail (2.1993) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Dec 2014 15:16:00 -0000 --Apple-Mail=_5BADA196-0D36-4A71-AC60-586F132A6051 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 06 Dec 2014, at 12:59, Andrew Turner wrote: >=20 > Author: andrew > Date: Sat Dec 6 11:59:35 2014 > New Revision: 275564 > URL: https://svnweb.freebsd.org/changeset/base/275564 >=20 > Log: > Use the unified syntax when generating assembly for clang. The clang = 3.5 > integrated assembler only accepts it. >=20 > MFC after: 1 week > Sponsored by: ABT Systems Ltd >=20 > Modified: > head/sys/arm/arm/stdatomic.c >=20 > Modified: head/sys/arm/arm/stdatomic.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/arm/arm/stdatomic.c Sat Dec 6 10:05:07 2014 = (r275563) > +++ head/sys/arm/arm/stdatomic.c Sat Dec 6 11:59:35 2014 = (r275564) > @@ -850,8 +850,13 @@ EMIT_FETCH_AND_OP_N(N, uintN_t, ldr, str > EMIT_FETCH_AND_OP_N(N, uintN_t, ldr, str, fetch_and_sub, "sub") = \ > EMIT_FETCH_AND_OP_N(N, uintN_t, ldr, str, fetch_and_xor, "eor") >=20 > +#ifdef __clang__ > +EMIT_ALL_OPS_N(1, uint8_t, "ldrb", "strb", "strbeq") > +EMIT_ALL_OPS_N(2, uint16_t, "ldrh", "strh", "strheq") > +#else > EMIT_ALL_OPS_N(1, uint8_t, "ldrb", "strb", "streqb") > EMIT_ALL_OPS_N(2, uint16_t, "ldrh", "strh", "streqh") > +#endif > EMIT_ALL_OPS_N(4, uint32_t, "ldr", "str", "streq") I already had this change in the clang350-import project branch, but unconditional. Should we just not standardize on the unified syntax, so all these ifdefs can be avoided? -Dimitry --Apple-Mail=_5BADA196-0D36-4A71-AC60-586F132A6051 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlSDHa8ACgkQsF6jCi4glqOfygCg5RsHX2vQyYCBIi3dJH3QShaz wCEAoMETMYfBeb49cvx3QVhtqZFCNqcc =lq3b -----END PGP SIGNATURE----- --Apple-Mail=_5BADA196-0D36-4A71-AC60-586F132A6051--