Date: Mon, 10 May 2021 08:30:59 GMT From: Mathieu Arnold <mat@FreeBSD.org> To: doc-committers@FreeBSD.org, dev-commits-doc-all@FreeBSD.org Subject: git: 28ad557ef6 - main - phb: Change instructions for new ports. Message-ID: <202105100830.14A8UxYO012732@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by mat: URL: https://cgit.FreeBSD.org/doc/commit/?id=28ad557ef678b8029c3a1a554a8790dc24a0f75c commit 28ad557ef678b8029c3a1a554a8790dc24a0f75c Author: Mathieu Arnold <mat@FreeBSD.org> AuthorDate: 2021-05-10 08:30:31 +0000 Commit: Mathieu Arnold <mat@FreeBSD.org> CommitDate: 2021-05-10 08:30:31 +0000 phb: Change instructions for new ports. --- .../en/articles/committers-guide/_index.adoc | 26 +++++++++++++--------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/documentation/content/en/articles/committers-guide/_index.adoc b/documentation/content/en/articles/committers-guide/_index.adoc index 9930532c42..5dff0376eb 100644 --- a/documentation/content/en/articles/committers-guide/_index.adoc +++ b/documentation/content/en/articles/committers-guide/_index.adoc @@ -3442,7 +3442,20 @@ When sending questions about this script to the {freebsd-ports}, please also CC ==== Any other things I need to know when I add a new port? Check the port, preferably to make sure it compiles and packages correctly. -This is the recommended sequence: + +The link:{porters-handbook}testing[Porters Handbook's Testing Chapter] contains more detailed instructions. +See the link:{porters-handbook}testing#testing-portclippy[Portclippy / Portfmt] and the link:{porters-handbook}testing#testing-poudriere[Poudriere] sections. + +You do not necessarily have to eliminate all warnings but make sure you have fixed the simple ones. + +If the port came from a submitter who has not contributed to the Project before, add that person's name to the link:{contributors}#contrib-additional[Additional Contributors] section of the FreeBSD Contributors List. + +Close the PR if the port came in as a PR. +To close a PR, change the state to `Issue Resolved` and the resolution as `Fixed`. + +[NOTE] +==== +If for some reason using link:{porters-handbook}testing#testing-poudriere[Poudriere] to test the new port is not possible, the bare minimum of testing includes this sequence: [source,shell] .... @@ -3455,15 +3468,8 @@ This is the recommended sequence: # make package .... -The link:{porters-handbook}[Porters Handbook] contains more detailed instructions. - -Use man:portlint[1] to check the syntax of the port. -You do not necessarily have to eliminate all warnings but make sure you have fixed the simple ones. - -If the port came from a submitter who has not contributed to the Project before, add that person's name to the link:{contributors}#contrib-additional[Additional Contributors] section of the FreeBSD Contributors List. - -Close the PR if the port came in as a PR. -To close a PR, change the state to `Issue Resolved` and the resolution as `Fixed`. +Note that poudriere is the reference for package building, it the port does not build in poudriere, it will be removed. +==== [[ports-qa-removing]] === Removing an Existing Port
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202105100830.14A8UxYO012732>