From owner-cvs-all@FreeBSD.ORG Fri Aug 17 18:29:00 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6553116A468; Fri, 17 Aug 2007 18:29:00 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: from rogue.navcom.lan (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 71ECB13C478; Fri, 17 Aug 2007 18:28:58 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: by rogue.navcom.lan (Postfix, from userid 1001) id C6DB03908; Fri, 17 Aug 2007 21:33:51 +0300 (EAT) Date: Fri, 17 Aug 2007 21:33:51 +0300 From: Mike Makonnen To: Dag-Erling Sm??rgrav Message-ID: <20070817183351.GA4405@rogue.navcom.lan> References: <200708170758.l7H7wRbV097007@repoman.freebsd.org> <86vebeiln6.fsf@ds4.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86vebeiln6.fsf@ds4.des.no> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD/7.0-CURRENT (i386) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d Makefile lockd nfslocking statd X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2007 18:29:00 -0000 On Fri, Aug 17, 2007 at 10:57:17AM +0200, Dag-Erling Sm??rgrav wrote: > Mike Makonnen writes: > > Log: > > The rc.d/nfslocking file controls two servers: rpc.statd and rpc.lockd. It worked well > > in most cases, except one. The 'restart' case was not working as expected. Specifically, > > it would stop both lockd and statd, but it would restart only statd (which appears first > > in the script). This is because rc.subr(8) contains code to guard against infinite > > recursion in the 'restart' casae. > > > > To fix this use the traditional approach of controlling only one server from one script by > > breaking out rc.d/nfslocking into its contituent parts: rc.d/lockd and rc.d/statd. Keep > > rc.d/nfslocking around but don't include it in the boot rcorder(8)ing. > > Wouldn't it have been better to name them rpc_lockd and rpc_statd, to > match their rc.conf variables? I considered that, but decided against it because the other rpc.* commands dont' follow that convention either: command rc.conf(5) knob rc.d script ------- --------------- ----------- rpc.ypupdated rpc_ypupdated_enable ypupdated rpc.ypxfrd nis_ypxfrd_enable ypxfrd rpc.yppasswdd nis_yppasswdd_enable yppasswdd It might be worth it to standardize these one way or the other for 8.0. Actually, now that I think about it there are quite a few other similar scripts and knobs which should probably be synced with the server names. Cheers. -- Mike Makonnen | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55 mtm @ FreeBSD.Org | FreeBSD - http://www.freebsd.org