Date: Fri, 17 Aug 2007 21:33:51 +0300 From: Mike Makonnen <mtm@FreeBSD.Org> To: Dag-Erling Sm??rgrav <des@freebsd.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d Makefile lockd nfslocking statd Message-ID: <20070817183351.GA4405@rogue.navcom.lan> In-Reply-To: <86vebeiln6.fsf@ds4.des.no> References: <200708170758.l7H7wRbV097007@repoman.freebsd.org> <86vebeiln6.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 17, 2007 at 10:57:17AM +0200, Dag-Erling Sm??rgrav wrote: > Mike Makonnen <mtm@FreeBSD.org> writes: > > Log: > > The rc.d/nfslocking file controls two servers: rpc.statd and rpc.lockd. It worked well > > in most cases, except one. The 'restart' case was not working as expected. Specifically, > > it would stop both lockd and statd, but it would restart only statd (which appears first > > in the script). This is because rc.subr(8) contains code to guard against infinite > > recursion in the 'restart' casae. > > > > To fix this use the traditional approach of controlling only one server from one script by > > breaking out rc.d/nfslocking into its contituent parts: rc.d/lockd and rc.d/statd. Keep > > rc.d/nfslocking around but don't include it in the boot rcorder(8)ing. > > Wouldn't it have been better to name them rpc_lockd and rpc_statd, to > match their rc.conf variables? I considered that, but decided against it because the other rpc.* commands dont' follow that convention either: command rc.conf(5) knob rc.d script ------- --------------- ----------- rpc.ypupdated rpc_ypupdated_enable ypupdated rpc.ypxfrd nis_ypxfrd_enable ypxfrd rpc.yppasswdd nis_yppasswdd_enable yppasswdd It might be worth it to standardize these one way or the other for 8.0. Actually, now that I think about it there are quite a few other similar scripts and knobs which should probably be synced with the server names. Cheers. -- Mike Makonnen | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55 mtm @ FreeBSD.Org | FreeBSD - http://www.freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070817183351.GA4405>