From owner-svn-src-all@freebsd.org Thu Jun 20 15:35:23 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D55D515BF45E for ; Thu, 20 Jun 2019 15:35:22 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FE9D8663F for ; Thu, 20 Jun 2019 15:35:22 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1561044919; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=dggJXCfMssWIeuUoDFuSGzfniRmCb3LZqNEWhlrXKzZeqoDHX3vH+ICSr9KnEVIdpKX0IczwwLsbt Ihd4GWkLjSAYC/QBlAGHbMdp2w6ESDzLwP8cKNGIs4swSy+voHyTfeNabS/G6Ck9LFu9Jw3t5bBOk7 18hjk5gkmtWgWFml34ywYc5YA8hDKaTY6RYzzgod93K/SyUG5cly8eAQHDuy+utfHK/08DR0sX+z+s PHCPbOLNSoWwUfkd+gqdTnO4Yh0ooMPFFY6GwtU6cqAuJxnKOaRcKMS3BZPlagJAIno6MYsJj5YCKd 66A54+Z3IwAhmGncWKriUp8KDv+haxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=EQGjIpPxTYanXDtCt0Dp1r9AcrTOnh0x4QgIYgGw2VQ=; b=oa/mOW8IudFNOoERvQz9hxBtHTPd4uu/E8yIjMhDTUd9RHNVrA3G1ZAaiwHxffIuFhKIbFdF00YFS Na3whkg3MY/MRibqyE3jkXVVw94jvUBj46uMY+2TXf4FkQPGDL52hubkOeyamiZtcMg0HNgRA0MS+a +NI4TBbMtxe+zdIXEoCaP8+yM838YWX7Mf9/Pwl11Ks/z+sfc2055LtMwp1OUhdkU7bDJ+w5hC/Jb3 Q6szS2ZOm6UkvINoiqQTkKexObOgzNDoEJvMWoh2aMsK9T3oATnYN6sg9dWSKRMBlEyIxmIU81TGcr BEaqzJjEAySGSDF6zfDjc+CuNz0krRA== ARC-Authentication-Results: i=1; outbound2.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=EQGjIpPxTYanXDtCt0Dp1r9AcrTOnh0x4QgIYgGw2VQ=; b=e3aNeTFRHVq+vPmtp1cQm1nbEDwlb2V8SUig0/bE1rR94Tf/7ohLqOeMcj7sm2E3cWSqw/QHgKJKC z6FAidkqDpXbhfYX2p9fkgn+uY1iAif5+NjvjJT4VA6OUFGupxBh1IGK3BUsoWKOwpUrzKLQWs0QzQ 3ceY0+Uy7jYqdo30636HptBXhuzZok9+diHMvhpXj11SFIE4juY1q3/Ue0XWsEemSDYjqenTMfmpBN jZvDBw2PBIvVoppWYrRcXoui2VDWbv7XUSOU3I1swVT4AHrLI15fBHSTt0Uo0ami91PmjTe/MWiPCc 1+r30rv1xuZQs2+vUYIEUGxaHKtVwMg== X-MHO-RoutePath: aGlwcGll X-MHO-User: ffe873e7-9370-11e9-b1d6-935efd94926c X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.eu.mailhop.org (Halon) with ESMTPSA id ffe873e7-9370-11e9-b1d6-935efd94926c; Thu, 20 Jun 2019 15:35:16 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x5KFZElv026517; Thu, 20 Jun 2019 09:35:14 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <155b84aec0183344d43b62be816ebf858a6b0e76.camel@freebsd.org> Subject: Re: svn commit: r349233 - head/sys/sys From: Ian Lepore To: Alan Somers Cc: src-committers , svn-src-all , svn-src-head Date: Thu, 20 Jun 2019 09:35:14 -0600 In-Reply-To: References: <201906201435.x5KEZTqH021513@repo.freebsd.org> <54f3bc97cbb485cdcc44b81c82c149ac9e46d42f.camel@freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FE9D8663F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jun 2019 15:35:23 -0000 On Thu, 2019-06-20 at 09:29 -0600, Alan Somers wrote: > On Thu, Jun 20, 2019 at 9:14 AM Ian Lepore wrote: > > > > On Thu, 2019-06-20 at 14:35 +0000, Alan Somers wrote: > > > Author: asomers > > > Date: Thu Jun 20 14:35:28 2019 > > > New Revision: 349233 > > > URL: https://svnweb.freebsd.org/changeset/base/349233 > > > > > > Log: > > > #include from sys/filio.h > > > > > > This fixes world build after r349231 > > > > > > Reported by: Jenkins > > > MFC after: 2 weeks > > > MFC-With: 349231 > > > Sponsored by: The FreeBSD Foundation > > > > > > Modified: > > > head/sys/sys/filio.h > > > > > > Modified: head/sys/sys/filio.h > > > ================================================================= > > > ==== > > > ========= > > > --- head/sys/sys/filio.h Thu Jun 20 14:34:45 > > > 2019 (r349232) > > > +++ head/sys/sys/filio.h Thu Jun 20 14:35:28 > > > 2019 (r349233) > > > @@ -40,6 +40,7 @@ > > > #ifndef _SYS_FILIO_H_ > > > #define _SYS_FILIO_H_ > > > > > > +#include > > > #include > > > > > > /* Generic file-descriptor ioctl's. */ > > > > > > > I wonder... is this one of those situations where it is better to > > use > > __int64_t in the struct, then #include ? I think the > > net > > effect there would be less pollution with other types? I've never > > seen > > written guidance about when to use the __names and _types.h, but > > I've > > always had the general impression that if you have to include a > > header > > from another system header, it's better to use the _header.h if it > > exists. > > > > -- Ian > > Good question. grep shows almost equal numbers of each (37 types.h > and 33 _types.h) in sys/sys. Do you think I should change it? > -Alan > Maybe some other folks will chime in with guidance... I phrased all that as questions hoping that someone who knows this stuff better would englighten us (or point us to docs). -- Ian