From owner-svn-src-head@FreeBSD.ORG Fri Jul 29 06:42:22 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 95137106564A; Fri, 29 Jul 2011 06:42:22 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-yi0-f54.google.com (mail-yi0-f54.google.com [209.85.218.54]) by mx1.freebsd.org (Postfix) with ESMTP id CBBE48FC0A; Fri, 29 Jul 2011 06:42:21 +0000 (UTC) Received: by yic13 with SMTP id 13so3008954yic.13 for ; Thu, 28 Jul 2011 23:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=CyNpUqRTio4wrAThCuhw5KLyi3LmsaIriw+SC0UxJxk=; b=plrRi2ROddyQjLt6b2ySvzJuM4ic6KQkJd6ItR47fFeUIYNDjuI2dG3rbfj1ojJ/uO dUt5l3V7um9DF6QpYAsYC0xXthZNSZ9yFDplIDq75E+BT7DP+NpdytC4mexVLYseoOWh 85uos0ouAlzapB50ISeA+Y+XLd/RchBu70Xhc= MIME-Version: 1.0 Received: by 10.150.238.19 with SMTP id l19mr348395ybh.301.1311921740943; Thu, 28 Jul 2011 23:42:20 -0700 (PDT) Sender: pluknet@gmail.com Received: by 10.150.200.3 with HTTP; Thu, 28 Jul 2011 23:42:20 -0700 (PDT) In-Reply-To: References: <201107191241.p6JCfvqw072816@svn.freebsd.org> <4E2C9012.602@freebsd.org> <4E2DB8AC.3000703@FreeBSD.org> <4E2DBCBF.2030402@freebsd.org> Date: Fri, 29 Jul 2011 10:42:20 +0400 X-Google-Sender-Auth: 9R0KnZ1jETAzC-w8FL7VMLMPG68 Message-ID: From: Sergey Kandaurov To: Attilio Rao Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Nathan Whitehorn , Andreas Tobler Subject: Re: svn commit: r224216 - in head/sys: ia64/ia64 mips/mips powerpc/aim sparc64/sparc64 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2011 06:42:22 -0000 On 28 July 2011 06:59, Attilio Rao wrote: > I think that the following patch may better reflect the definition of size_t: > http://www.freebsd.org/~attilio/sintrcnt-fixup32.diff > > Do you think you can test it out? Hi. FYI, I just finished buildtesting the patch with make universe. No stopping build errors found (surely, that still doesn't indicate that it works). > > 2011/7/25 Attilio Rao : >> Guys, I'm a bit out of that for a couple of days, flying to another >> continent, I'm not entirely sure the patch is right because I think we >> need an unified approach for specifying a 32-bits value, but you can >> check-in as a showstopper for the moment, I will make a better one in >> a couple of days. >> >> Attilio >> >> 2011/7/25 Nathan Whitehorn : >>> On 07/25/11 13:40, Andreas Tobler wrote: >>>> >>>> On 24.07.11 23:35, Nathan Whitehorn wrote: >>>>> >>>>> On 07/19/11 07:41, Attilio Rao wrote: >>>>>> >>>>>> Author: attilio >>>>>> Date: Tue Jul 19 12:41:57 2011 >>>>>> New Revision: 224216 >>>>>> URL: http://svn.freebsd.org/changeset/base/224216 >>>>>> >>>>>> Log: >>>>>> On 64 bit architectures size_t is 8 bytes, thus it should use an 8 bytes >>>>>> storage. >>>>>> Fix the sintrcnt/sintrnames specification. >>>>>> >>>>>> No MFC is previewed for this patch. >>>>>> >>>>> >>>>> These also need to be .long on 32-bit PowerPC, otherwise this change >>>>> triggers kernel panics and faults in sysctl. Please change it as quickly >>>>> as possible. >>>> >>>> Like the below? >>>> >>>> I'll test and I could commit if ok. (Build and approval) >>>> >>>> Gruss, >>>> Andreas >>>> >>>> Index: locore32.S >>>> =================================================================== >>>> --- locore32.S (revision 224326) >>>> +++ locore32.S (working copy) >>>> @@ -91,13 +91,13 @@ >>>> GLOBAL(intrnames) >>>> .space INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 >>>> GLOBAL(sintrnames) >>>> - .word INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 >>>> + .long INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 >>>> >>>> .align 4 >>>> GLOBAL(intrcnt) >>>> .space INTRCNT_COUNT * 4 * 2 >>>> GLOBAL(sintrcnt) >>>> - .word INTRCNT_COUNT * 4 * 2 >>>> + .long INTRCNT_COUNT * 4 * 2 >>>> >>>> .text >>>> .globl btext >>> >>> Exactly like that. -- wbr, pluknet