Date: Sun, 26 Sep 2010 01:01:35 +0200 From: Andy Kosela <akosela@andykosela.com> To: dougb@FreeBSD.org, az@FreeBSD.org Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/ports-mgmt/bpkg Makefile ports/ports-mgmt/bpkg/files bpkg.8 bpkg.sh.in Message-ID: <4c9e7f4f.9pWCZ1OmPFLaLfcg%akosela@andykosela.com> In-Reply-To: <4C9E70E3.3000004@FreeBSD.org> References: <201009251455.o8PEtSxM036322@repoman.freebsd.org> <4C9E70E3.3000004@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Doug Barton <dougb@FreeBSD.org> wrote: > FYI, it's never necessary to do 'cat $file | grep' you can always do > 'grep $file' instead. > > The bit on finding the directory for a port (the ones that start with > pwd= in the diff) can also be done a bit more efficiently with this at > the beginning: > > grep -m1 "/$e|" INDEX Yeah I agree, will incorporate your suggestions into the code. However -m1 option is not useful here as: $ grep -m1 "/$tin|" INDEX lists only zh-tin (first match), where first and foremost we are looking for tin. --Andy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4c9e7f4f.9pWCZ1OmPFLaLfcg%akosela>