From owner-freebsd-current@FreeBSD.ORG  Mon Dec 31 14:58:24 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 7119B288
 for <freebsd-current@freebsd.org>; Mon, 31 Dec 2012 14:58:24 +0000 (UTC)
 (envelope-from yanegomi@gmail.com)
Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com
 [209.85.214.178])
 by mx1.freebsd.org (Postfix) with ESMTP id 2D6A88FC0C
 for <freebsd-current@freebsd.org>; Mon, 31 Dec 2012 14:58:23 +0000 (UTC)
Received: by mail-ob0-f178.google.com with SMTP id eh20so11369269obb.23
 for <freebsd-current@freebsd.org>; Mon, 31 Dec 2012 06:58:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=WIlBJnyYsstq/KdsiLcLwWXZMoN+5qwk8lfIqDIr3Ns=;
 b=tDkXLl6PmBHT2IeaLncQ4O/eoVbE6xnnH34Uw6QNqMlVCGYomoFNPs/rLwLpyq/OYh
 jjuBk0s1D1x2n2suMxNYlhIutD7wm+sCd5osoGsVbB1jghIa5s5zjkVad8wsUmBSJn8/
 kdLVbXz8F0IGRddj+crBkVWLj0XmgYYyT7KAWBloss33FamKNpTFeMYyIQw77BFg+xS6
 ZV7xo6mPVb7/H1EWB0mNa+xOo2YnT2X5yCthBp3YCVafn41l6XBURg0FiSZ6WIZmTpm7
 zkjoUQRi9J26c/oYOfaHUdYbVAlg7bFYItatOQ5U5Jkkq/OtXKnMJyesSJ3g4vj6mZWl
 ZkCg==
MIME-Version: 1.0
Received: by 10.60.172.164 with SMTP id bd4mr22234475oec.51.1356965896977;
 Mon, 31 Dec 2012 06:58:16 -0800 (PST)
Received: by 10.76.143.33 with HTTP; Mon, 31 Dec 2012 06:58:16 -0800 (PST)
In-Reply-To: <1905046872.1604317.1356954929867.JavaMail.root@erie.cs.uoguelph.ca>
References: <CAGH67wQLuOWd+Zqh==b0XPA9haK+uMZM1W0+=XhjxgOpxo=yYQ@mail.gmail.com>
 <1905046872.1604317.1356954929867.JavaMail.root@erie.cs.uoguelph.ca>
Date: Mon, 31 Dec 2012 06:58:16 -0800
Message-ID: <CAGH67wTswm=G73SUW2t_H0oJ20zoikDmAm+5dqye2rubQWwcFQ@mail.gmail.com>
Subject: Re: svn commit: r244604 - head/usr.sbin/gssd
From: Garrett Cooper <yanegomi@gmail.com>
To: Rick Macklem <rmacklem@uoguelph.ca>
Content-Type: text/plain; charset=ISO-8859-1
Cc: bf1783@gmail.com, freebsd-current@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Dec 2012 14:58:24 -0000

On Mon, Dec 31, 2012 at 3:55 AM, Rick Macklem <rmacklem@uoguelph.ca> wrote:

...

> WITHOUT_KERBEROS is used other places, like telnetd. Were you aware of that?
> (I just thought it would keep it consistent, but if you think it is better
>  to use a different name, I don't care.)

Ah, no. I wasn't aware of that :). Given that something else has been
standardized around the tree, I agree that your approach of using
WITHOUT_KERBEROS is ok. I wasn't keen on the name just because it
could have simplified the code using a positive instead of a negative
predicate in the #ifdef.

I looked at the updated patch and it looks good to me :).

Thanks!
-Garrett