From owner-svn-src-all@freebsd.org Thu Nov 14 19:56:43 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9C5E41B1C05; Thu, 14 Nov 2019 19:56:43 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47DXLM3jB7z4cqd; Thu, 14 Nov 2019 19:56:43 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 634B058F7; Thu, 14 Nov 2019 19:56:43 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id xAEJuhSL077033; Thu, 14 Nov 2019 19:56:43 GMT (envelope-from bdragon@FreeBSD.org) Received: (from bdragon@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id xAEJuh1A077032; Thu, 14 Nov 2019 19:56:43 GMT (envelope-from bdragon@FreeBSD.org) Message-Id: <201911141956.xAEJuh1A077032@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: bdragon set sender to bdragon@FreeBSD.org using -f From: Brandon Bergren Date: Thu, 14 Nov 2019 19:56:43 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r354713 - head/sys/conf X-SVN-Group: head X-SVN-Commit-Author: bdragon X-SVN-Commit-Paths: head/sys/conf X-SVN-Commit-Revision: 354713 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2019 19:56:43 -0000 Author: bdragon Date: Thu Nov 14 19:56:42 2019 New Revision: 354713 URL: https://svnweb.freebsd.org/changeset/base/354713 Log: [PowerPC64] Fix broken kernel modules due to LLD 9+ TOC optimization LLD9 introduced a TOC optimization that isn't compatible with kernel dynamic linker causing panic when loading kernel modules (pf, linuxkpi etc.) This patch disables TOC optimization when building kernel modules. Submitted by: Alfredo Dal'Ava Junior Approved by: jhibbits (mentor) Differential Revision: https://reviews.freebsd.org/D22317 Modified: head/sys/conf/kmod.mk Modified: head/sys/conf/kmod.mk ============================================================================== --- head/sys/conf/kmod.mk Thu Nov 14 18:38:56 2019 (r354712) +++ head/sys/conf/kmod.mk Thu Nov 14 19:56:42 2019 (r354713) @@ -169,6 +169,10 @@ CFLAGS+= -funwind-tables .if ${MACHINE_CPUARCH} == powerpc CFLAGS+= -mlongcall -fno-omit-frame-pointer +.if ${LINKER_TYPE} == "lld" +# TOC optimization in LLD (9.0) currently breaks kernel modules, so disable it +LDFLAGS+= --no-toc-optimize +.endif .endif .if ${MACHINE_CPUARCH} == mips