From owner-freebsd-bugs@freebsd.org  Tue Sep  5 19:47:22 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA44DE1BD26
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Tue,  5 Sep 2017 19:47:22 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4C4F877194
 for <freebsd-bugs@FreeBSD.org>; Tue,  5 Sep 2017 19:47:22 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v85JlLkX076642
 for <freebsd-bugs@FreeBSD.org>; Tue, 5 Sep 2017 19:47:21 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 222077] geli(8) writing uninitialized memory out to disk
Date: Tue, 05 Sep 2017 19:47:22 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.1-RELEASE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: cem@freebsd.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-222077-8-LGdGwCApt1@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-222077-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-222077-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Sep 2017 19:47:23 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222077

--- Comment #2 from Conrad Meyer <cem@freebsd.org> ---
It seems like the math in g_eli_auth_run (g_eli_integrity.c) is kind of
dubious, even ignoring the data leak.  Does it even work?  I think it is ma=
king
some invalid assumptions about C division rounding.  It looks like the logic
was copied from g_eli_crypto_run (g_eli_privacy.c).

I suspect this change wouldn't hurt, but I don't think it fixes the problem:

--- a/sys/geom/eli/g_eli_integrity.c
+++ b/sys/geom/eli/g_eli_integrity.c
@@ -445,7 +445,7 @@ g_eli_auth_run(struct g_eli_worker *wr, struct bio *bp)
                size +=3D sizeof(*crda) * nsec;
                size +=3D G_ELI_AUTH_SECKEYLEN * nsec;
                size +=3D sizeof(uintptr_t);      /* Space for alignment. */
-               data =3D malloc(size, M_ELI, M_WAITOK);
+               data =3D malloc(size, M_ELI, M_WAITOK | M_ZERO);
                bp->bio_driver2 =3D data;
                p =3D data + encr_secsize * nsec;
        }

I think "nsec" is calculated wrong (and differently!) in both
g_eli_auth_write_done and g_eli_auth_run.

Probably avoid using geli in integrity mode if you care about privacy, for =
now.

--=20
You are receiving this mail because:
You are the assignee for the bug.=