From owner-svn-src-head@freebsd.org Wed Mar 1 16:10:51 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90139CE4673; Wed, 1 Mar 2017 16:10:51 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47FE0D91; Wed, 1 Mar 2017 16:10:50 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v21GAn3w057020; Wed, 1 Mar 2017 08:10:49 -0800 (PST) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd-rwg@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v21GAnQF057019; Wed, 1 Mar 2017 08:10:49 -0800 (PST) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201703011610.v21GAnQF057019@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r314464 - head/usr.sbin/yppush In-Reply-To: <1488383691.60166.12.camel@freebsd.org> To: Ian Lepore Date: Wed, 1 Mar 2017 08:10:49 -0800 (PST) CC: "Ngie Cooper (yaneurabeya)" , Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 16:10:51 -0000 [ Charset ISO-8859-1 unsupported, converting... ] > On Tue, 2017-02-28 at 21:53 -0800, Rodney W. Grimes wrote: > > -- Start of PGP signed section. > > [ Charset UTF-8 unsupported, converting... ] > > > > > > > > > > > > > > On Feb 28, 2017, at 21:38, Rodney W. Grimes > > > N85.dnsmgr.net> wrote: > > > > > > > > Would it be possible to not do this as 1000 commits? > > > Yes, but I?m trying to do this in a way that allows me to > > > backport all of the changes as easily as possible to ^/stable/10 > > > (on the other side of the coin, I?ve run into dependent commits of > > > other MFCs that required sweeping changes in order to make my > > > changes possible). > > > I do think your point is valid though and I can probably strike > > > some middle ground with my changes. I think grouping it up by 2nd > > > level directory (like I did with usr.bin/svn) makes the most sense. > > > Thank you, > > Yes, that is what I was thinking.??Note that I dont agree with this > > change, > > but I have probably missed a discussion that is allowing it to move > > forward. > > It makes the logfiles of make output now src tree possition > > dependent, > > but I am probalby the only person in the universe that has ever run a > > diff on the output of make world. > > > > It may also be possible to split this into some phases to reduce some > > of > > your issues, only do the {.CURDIR}/../../foo -> ${SRCTOP}/bar/foo in > > one pass and > > some of the other fixes in another pass. > > > > > > You're not the only one who has diffed build output logs (I suspect > anyone who has to maintain a non-trivial build infrastructure has done > so), and you're not the only one who thinks that changing relative > paths to absolute is a bad idea. Was there any @developers or @hackers discussion on this before such a wide sweeping and non-trival change was undertaken? I may of wrongly assumed that this was discussed and though to be a good idea for some reason(s). -- Rod Grimes rgrimes@freebsd.org