From owner-freebsd-geom@FreeBSD.ORG Mon Jun 18 12:42:10 2012 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 826501065672; Mon, 18 Jun 2012 12:42:10 +0000 (UTC) (envelope-from john@saltant.com) Received: from homiemail-a74.g.dreamhost.com (caiajhbdccah.dreamhost.com [208.97.132.207]) by mx1.freebsd.org (Postfix) with ESMTP id 55BF58FC1A; Mon, 18 Jun 2012 12:42:10 +0000 (UTC) Received: from homiemail-a74.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a74.g.dreamhost.com (Postfix) with ESMTP id 6581A67C06E; Mon, 18 Jun 2012 05:42:04 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=saltant.com; h=message-id:date :from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; q=dns; s=saltant.com; b=bpCf89QLM4VR042su0F4hzbOqARBwuanM/5RSgh5RnI6lrwG3nNbR1m2SfPQJ 6d/NCUdKLY/qTjqweTa2GPd1KQqcg7gJ7DG4xU7YkBLTxVGeJH0BB1MkKkeC8QHV XUtWGwSIrvs2qSLLQOiqKTtYaDPHRmExFcdvxMEPk8kEBE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=saltant.com; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; s=saltant.com; bh=bfpU2 3juBPv+uPoNbDqpLkOoVOE=; b=UpT5h6oIvmqdYdyOatpN9Jm7lQu+kfXkME0BC uSTWpmpM0fJJ/NvgCf7PmVwAV3cfkSN7DJVnNP85s1DUn9E/rUngGEq36uWbU5xq MsPkMRWaX8RBHSI4bNQShgkyXe4GAA+Aob60UV9RMVyZ26YuwJh+cSCNGtyuZ5jQ lEwkhk= Received: from imago.y.saltant.net (vice.saltant.net [96.227.187.16]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: john@saltant.com) by homiemail-a74.g.dreamhost.com (Postfix) with ESMTPSA id 18F2E67C06D; Mon, 18 Jun 2012 05:42:04 -0700 (PDT) Message-ID: <4FDF221A.7080205@saltant.com> Date: Mon, 18 Jun 2012 08:42:02 -0400 From: "John W. O'Brien" Organization: Saltant Solutions User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <4FD3B8D5.7030906@saltant.com> <20120610081337.GL1379@garage.freebsd.pl> <4FDB16B4.4060705@saltant.com> <20120615200924.GE1399@garage.freebsd.pl> <4FDBB453.9060806@saltant.com> <20120617103029.GK1399@garage.freebsd.pl> In-Reply-To: <20120617103029.GK1399@garage.freebsd.pl> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-geom@freebsd.org Subject: Re: Scope and purpose of each kind geli key X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2012 12:42:10 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/17/2012 06:30 AM, Pawel Jakub Dawidek wrote: > On Fri, Jun 15, 2012 at 06:16:51PM -0400, John W. O'Brien wrote: >> @@ -58,7 +58,7 @@ .Op Fl i Ar iterations .Op Fl J Ar newpassfile >> .Op Fl K Ar newkeyfile -.Op Fl l Ar keylen +.Op Fl l Ar >> datakeylen > > I wouldn't change that. It is called 'keylen' also in geli(8) > usage. > >> @@ -83,7 +83,7 @@ .Op Fl d .Op Fl a Ar aalgo .Op Fl e Ar ealgo >> -.Op Fl l Ar keylen +.Op Fl l Ar datakeylen > > Same here. > >> -.It Fl l Ar keylen -Key length to use with the given >> cryptographic algorithm. +.It Fl l Ar datakeylen > > And here. The /keylen/datakeylen/ change shows up in four places, including the usage section. % grep -n keylen geli.8 61:.Op Fl l Ar datakeylen 86:.Op Fl l Ar datakeylen 322:.It Fl l Ar datakeylen 445:.It Fl l Ar datakeylen I thought about changing the 'keyfile' parameter name too, but that applies in loader.conf, so I left it alone. In any case, I don't feel that strongly about it. I'll back out those four lines and post an updated patch to the PR. John -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJP3yIYAAoJEEdKvTwaez9wNJYH/3rowPCQIxqiVrd4f0OmYsn7 Us9Sx/udaknznfhW824r040EsXZDD0uC/Ka22XKMLXwAeTMIrQPGdUox6sxMuQuF 6S/g0I3rti+ECwEmERnIYtbspHWO1HktvrpStdtwVag98H9uFtd9dKhPYMJIK96t jFKx5VDUyP5KL+4WbM/0avRJqilGs5Xk4nnZ2Ad68H6XZzWPd7VRMtaMaQrQ6Bmt 43xG4nalbQ7bCzWSE0rhcU+znAVxKtlG8cbH7H/lvcgbrUUK10L0sBDHZ4qjbciC V8dvg3rfQvUzZsA9gzWwBtbxRSyB4XhRmryckc8cYhldDDE1P9pB1PewfyVxv/s= =Spam -----END PGP SIGNATURE-----