Date: Wed, 15 Jul 2020 07:32:43 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Adam Weinberger <adamw@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r542249 - in head: devel/msgpack math/calc security/gnupg security/gnupg1 sysutils/z Message-ID: <20200715073243.GA31163@FreeBSD.org> In-Reply-To: <202007150728.06F7SSHC097792@repo.freebsd.org> References: <202007150728.06F7SSHC097792@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 15, 2020 at 07:28:28AM +0000, Adam Weinberger wrote: > New Revision: 542249 > URL: https://svnweb.freebsd.org/changeset/ports/542249 > > Log: > Unmute some build commands > > @@ -30,7 +30,7 @@ USE_GCC= yes > > post-patch: > # GoogleTest doesn't support C++98 consumers since 1.10.0 > - @${REINPLACE_CMD} -e 's/c++98/c++11/' ${WRKSRC}/CMakeLists.txt > + ${REINPLACE_CMD} -e 's/c++98/c++11/' ${WRKSRC}/CMakeLists.txt This is not the build, this is patch command. In the ports, patching traditionally happens silently. > post-install: > - @${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/calc \ > + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/calc \ > ${STAGEDIR}${PREFIX}/lib/lib*.so Stripping also typically happens silenty. > - @${TOUCH} ${WRKSRC}/doc/*.texi > + ${TOUCH} ${WRKSRC}/doc/*.texi Touching dummy files (cookies) definitely should happen silently. > post-install: > - @${MV} ${STAGEDIR}${DATADIR}/help*.txt ${STAGEDIR}${DOCSDIR} > + ${MV} ${STAGEDIR}${DATADIR}/help*.txt ${STAGEDIR}${DOCSDIR} This one is correct. > post-install-DOCS-on: > - @${MKDIR} ${STAGEDIR}${DOCSDIR} > + ${MKDIR} ${STAGEDIR}${DOCSDIR} > > do-install: > - @${MKDIR} ${STAGEDIR}${DATADIR} > + ${MKDIR} ${STAGEDIR}${DATADIR} We usually mute mkdir's. Please do not "fix" what ain't broken, this just creates needless repochurn, pessimizes "svn blame" and solves no real problem, but just makes things less consistent throughout the ports tree. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200715073243.GA31163>