From owner-svn-ports-all@freebsd.org  Wed Jul 15 07:32:43 2020
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id F06D735C544;
 Wed, 15 Jul 2020 07:32:43 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4B68HH694Zz41TQ;
 Wed, 15 Jul 2020 07:32:43 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id C0605D5C; Wed, 15 Jul 2020 07:32:43 +0000 (UTC)
Date: Wed, 15 Jul 2020 07:32:43 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Adam Weinberger <adamw@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r542249 - in head: devel/msgpack math/calc
 security/gnupg security/gnupg1 sysutils/z
Message-ID: <20200715073243.GA31163@FreeBSD.org>
References: <202007150728.06F7SSHC097792@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202007150728.06F7SSHC097792@repo.freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2020 07:32:44 -0000

On Wed, Jul 15, 2020 at 07:28:28AM +0000, Adam Weinberger wrote:
> New Revision: 542249
> URL: https://svnweb.freebsd.org/changeset/ports/542249
> 
> Log:
>   Unmute some build commands
> 
> @@ -30,7 +30,7 @@ USE_GCC=	yes
>  
>  post-patch:
>  # GoogleTest doesn't support C++98 consumers since 1.10.0
> -	@${REINPLACE_CMD} -e 's/c++98/c++11/' ${WRKSRC}/CMakeLists.txt
> +	${REINPLACE_CMD} -e 's/c++98/c++11/' ${WRKSRC}/CMakeLists.txt

This is not the build, this is patch command.  In the ports, patching
traditionally happens silently.

>  post-install:
> -	@${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/calc \
> +	${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/calc \
>  		${STAGEDIR}${PREFIX}/lib/lib*.so

Stripping also typically happens silenty.

> -	@${TOUCH} ${WRKSRC}/doc/*.texi
> +	${TOUCH} ${WRKSRC}/doc/*.texi

Touching dummy files (cookies) definitely should happen silently.

>  post-install:
> -	@${MV} ${STAGEDIR}${DATADIR}/help*.txt ${STAGEDIR}${DOCSDIR}
> +	${MV} ${STAGEDIR}${DATADIR}/help*.txt ${STAGEDIR}${DOCSDIR}

This one is correct.

>  post-install-DOCS-on:
> -	@${MKDIR} ${STAGEDIR}${DOCSDIR}
> +	${MKDIR} ${STAGEDIR}${DOCSDIR}
>  
>  do-install:
> -	@${MKDIR} ${STAGEDIR}${DATADIR}
> +	${MKDIR} ${STAGEDIR}${DATADIR}

We usually mute mkdir's.  Please do not "fix" what ain't broken, this
just creates needless repochurn, pessimizes "svn blame" and solves
no real problem, but just makes things less consistent throughout the
ports tree.

./danfe