From owner-cvs-all Thu Mar 7 11:29:51 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id A3C2D37B402; Thu, 7 Mar 2002 11:29:41 -0800 (PST) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.2/8.12.2) with ESMTP id g27JTZPi029110; Thu, 7 Mar 2002 22:29:39 +0300 (MSK) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.2/8.12.2/Submit) id g27JTWLR029109; Thu, 7 Mar 2002 22:29:33 +0300 (MSK) Date: Thu, 7 Mar 2002 22:29:31 +0300 From: "Andrey A. Chernov" To: Mark Murray Cc: obrien@FreeBSD.org, "M. Warner Losh" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/rwall rwall.c Message-ID: <20020307192930.GA29021@nagual.pp.ru> References: <20020307105542.A61459@dragon.nuxi.com> <200203071913.g27JD3RV038460@grimreaper.grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200203071913.g27JD3RV038460@grimreaper.grondar.org> User-Agent: Mutt/1.3.27i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Mar 07, 2002 at 19:13:03 +0000, Mark Murray wrote: > > On Thu, Mar 07, 2002 at 04:31:22PM +0000, Mark Murray wrote: > > > > But the two constructs are different. In the prior code, if mkstemp > > > > returns -1, then fdopen wouldn't be called. In the new code it is. > > > > > > I have reverted this, folks! > > > > Thanks. I hate to ask... but I saw this type of change in other files > > besides just rwall.c. rwall.c was just the one I picked to respond to. > > I've been doing this for months. I also notice that you break 8bit cleannes of 'ls' by removing 'unsigned' from the char. I fear that this kind of change can break 8bit in other places too. Do you remember where else you make similar change? -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message