From owner-freebsd-bugs@freebsd.org  Tue Oct 18 09:17:19 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 831DBC15F6A
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Tue, 18 Oct 2016 09:17:19 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7296FB7C
 for <freebsd-bugs@FreeBSD.org>; Tue, 18 Oct 2016 09:17:19 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u9I9HJ46044159
 for <freebsd-bugs@FreeBSD.org>; Tue, 18 Oct 2016 09:17:19 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 212914] CAM: SATA drives are getting deleted and then re-added
 after controller rescan
Date: Tue, 18 Oct 2016 09:17:19 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-RC1
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: kashyap.desai@broadcom.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-212914-8-E8Ze7ns14e@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-212914-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-212914-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Oct 2016 09:17:19 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212914

--- Comment #4 from Kashyap <kashyap.desai@broadcom.com> ---
This issue is fixed using below patch. Please review and let me know if thi=
s is
a correct fix.  Root cause is - "Checksum is updated using different serial
number. One without removing extra spaces and another with additional space=
s.
Because of that, any rescan of ATA disk is defected as different ATA drive,=
 so
it is removed and re-added later. "


Index: scsi_xpt.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- scsi_xpt.c  (revision 307137)
+++ scsi_xpt.c  (working copy)
@@ -1600,8 +1600,8 @@
                                  sizeof(struct scsi_inquiry_data));

                        if (have_serialnum)
-                               MD5Update(&context, serial_buf->serial_num,
-                                         serial_buf->length);
+                               MD5Update(&context, path->device->serial_nu=
m,
+                                   path->device->serial_num_len);

                        MD5Final(digest, &context);
                        if (bcmp(softc->digest, digest, 16) =3D=3D 0)

--=20
You are receiving this mail because:
You are the assignee for the bug.=