From owner-svn-src-all@FreeBSD.ORG  Fri May 11 14:54:39 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 16575106564A;
	Fri, 11 May 2012 14:54:39 +0000 (UTC) (envelope-from ache@vniz.net)
Received: from vniz.net (vniz.net [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id 824828FC15;
	Fri, 11 May 2012 14:54:34 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by vniz.net (8.14.5/8.14.5) with ESMTP id q4BEsX7i019263;
	Fri, 11 May 2012 18:54:33 +0400 (MSK) (envelope-from ache@vniz.net)
Received: (from ache@localhost)
	by localhost (8.14.5/8.14.5/Submit) id q4BEsXfl019262;
	Fri, 11 May 2012 18:54:33 +0400 (MSK) (envelope-from ache)
Date: Fri, 11 May 2012 18:54:32 +0400
From: Andrey Chernov <ache@FreeBSD.ORG>
To: Konstantin Belousov <kib@FreeBSD.ORG>
Message-ID: <20120511145432.GA19173@vniz.net>
Mail-Followup-To: Andrey Chernov <ache@freebsd.org>,
	Konstantin Belousov <kib@FreeBSD.ORG>, src-committers@FreeBSD.ORG,
	svn-src-all@FreeBSD.ORG, svn-src-head@FreeBSD.ORG
References: <201205111129.q4BBT85G081093@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201205111129.q4BBT85G081093@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG,
	src-committers@FreeBSD.ORG
Subject: Re: svn commit: r235266 - head/lib/libc/stdlib
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 May 2012 14:54:39 -0000

Thanks, but in this two places old errno value should be saved across
free() because free() may damage it:

On Fri, May 11, 2012 at 11:29:08AM +0000, Konstantin Belousov wrote:
...
> +			if (lstat(resolved, &sb) != 0) {
> +				if (m)
> +					free(resolved);
> +
				return (NULL);
...
> +				errno = ENOTDIR;
>  			if (m)
>  				free(resolved);
>  			return (NULL);


-- 
http://ache.vniz.net/