Date: Fri, 28 Mar 2008 23:58:02 -1000 (HST) From: Jeff Roberson <jroberson@chesapeake.net> To: Hans Petter Selasky <hselasky@c2i.net> Cc: arch@freebsd.org, freebsd-arch@freebsd.org Subject: Re: timeout/callout small step forward Message-ID: <20080328235600.O72156@desktop> In-Reply-To: <200803291013.28797.hselasky@c2i.net> References: <10004.1205307334@critter.freebsd.dk> <20080312152744.I29518@fledge.watson.org> <20080328202602.N72156@desktop> <200803291013.28797.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 29 Mar 2008, Hans Petter Selasky wrote:
> Hi,
>
> How does this patch handle when multiple callouts use the same mutex ? Imagine
> that two threads are about to lock the same mutex, then the second thread
> will get nowhere while waiting for the first thread to execute the callback.
You are worried that there will be too much contention or that there is
some correctness issue?
If you're worried about contention, it would seem that most callers use
some per-object mutex for the callout. So there isn't likely to be
much contention among callouts.
>
> I think the solution is that callbacks are put in a tree. Giant locked
> callbacks go all into the same tree. Else the user of callouts is responsible
> for making up the tree.
>
> struct callout {
> struct thread *exec_td;
> struct callout *parent;
> };
>
> struct callout *c;
>
> while (c->parent != NULL) {
> c = c->parent;
> }
>
> if (c->exec_td != NULL) {
> callout should go into the same thread;
> } else {
> pick the next free thread and set "c->exec_td"
> }
>
> Callouts that belong to the same tree are run from the same thread. This does
> not only apply for callouts, but also multithreaded node systems ...
>
> Yours
> --HPS
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080328235600.O72156>