From owner-freebsd-net@FreeBSD.ORG Wed Nov 10 23:42:28 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 70090106564A for ; Wed, 10 Nov 2010 23:42:28 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3B5458FC13 for ; Wed, 10 Nov 2010 23:42:27 +0000 (UTC) Received: by pvc22 with SMTP id 22so333019pvc.13 for ; Wed, 10 Nov 2010 15:42:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=TphuLLmCKeZlaB3CT+bCG3DgXcITUppb7vDG//uLeAc=; b=tmqHunSk86MkGufT7G41mXyqzcIeiwCdIPyzcwa3+/179SPyzVZpXIO4CuiWXTfNBj gnsZvzYk1QvZfWr+yuNYL1xXKjzr9PLdPnJXRqz0vFtte4qGUekv4UE7eA7EECdOnkTJ EOIHmcx3du8AMMxiV8xY27ZcrP4/DpyxIBnCk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=K65tx30zVtpQcSoiThh9ml+ah/ZsVSjyTGDqNsJ6v0w6EEMX9bdPHykyzJEbjZ7MEs CNly3b0l4B1vlW3sVjMfIt9VYdEptv78+fJgevH3eSLP9p2jIA2Tn2E0Qcga/0RzY6Hs oQRZ4oFdO62vWevvygPZYjk9BJOZf1zQsmP84= Received: by 10.142.97.15 with SMTP id u15mr8190631wfb.389.1289432546055; Wed, 10 Nov 2010 15:42:26 -0800 (PST) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id w14sm1494536wfd.6.2010.11.10.15.42.22 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 10 Nov 2010 15:42:23 -0800 (PST) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Wed, 10 Nov 2010 15:41:28 -0800 From: Pyun YongHyeon Date: Wed, 10 Nov 2010 15:41:28 -0800 To: Yamagi Burmeister Message-ID: <20101110234128.GC13340@michelle.cdnetworks.com> References: <20101109011410.GB1275@michelle.cdnetworks.com> <20101109190713.GA7766@michelle.cdnetworks.com> <20101109213421.GE7766@michelle.cdnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101109213421.GE7766@michelle.cdnetworks.com> User-Agent: Mutt/1.4.2.3i Cc: freebsd-net@freebsd.org Subject: Re: [patch] WOL support for nfe(4) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2010 23:42:28 -0000 On Tue, Nov 09, 2010 at 01:34:21PM -0800, Pyun YongHyeon wrote: > On Tue, Nov 09, 2010 at 10:01:36PM +0100, Yamagi Burmeister wrote: > > On Tue, 9 Nov 2010, Pyun YongHyeon wrote: > > > > >>No, the link stays at 1000Mbps so the driver must manually switch back > > >>to 10/100Mbps. > > >> > > > > > >Hmm, this is real problem for WOL. Establishing 1000Mbps link to > > >accept WOL frames is really bad idea since it can draw more power > > >than 375mA. Consuming more power than 375mA is violation of > > >PCI specification and some system may completely shutdown the power > > >to protect hardware against over-current damage which in turn means > > >WOL wouldn't work anymore. Even if WOL work with 1000Mbps link for > > >all nfe(4) controllers, it would dissipate much more power. > > > > > >Because nfe(4) controllers are notorious for using various PHYs, > > >it's hard to write a code to reliably establish 10/100Mbps link in > > >driver. In addition, nfe(4) is known to be buggy in link state > > >handling such that forced media selection didn't work well. I'll > > >see what could be done in this week if I find spare time. > > > > Hmm... Maybe just add a hint to the manpage that WOL is possible broken? > > I think this may not be enough. Because it can damage your hardware > under certain conditions if protection circuit was not there. > Ok, I updated patch which will change link speed to 10/100Mps when shutdown/suspend is initiated. You can get the patch at the following URL. Please give it a try and let me know whether it really changes link speed to 10/100Mbps. If it does not work as expected, show me the dmesg output of your system. http://people.freebsd.org/~yongari/nfe/nfe.wol.patch2 > > Nevertheless thanks for your work it's much appreciated :) > > > > >>>o When you put your box into suspend mode, can you wake up your box > > >>>with WOL magic packet? > > >> > > >>I'm sorry but I can't test that since none of those boxes supports > > >>suspend: > > >> > > >> % sysctl hw.acpi.suspend_state > > >> hw.acpi.suspend_state: NONE > > >> > > > > > >You can switch to suspend mode with "acpiconf -s1". If all goes > > >well, driver would put the controller into suspend mode after > > >reprogramming controller to accept WOL frames. After that, you can > > >wakeup the box by sending a WOL magic packet. > > > > Okay, It thought that S3 is required. Put the box into S1, waited some > > minutes and send the magic packet. The video didn't resume but I was > > able to login via SSH. So waking up by sending the WOL magic packet > > works. > > > > Thanks for testing. Probably you want to poke jkim@ to address > video resume issue.