From owner-cvs-sys  Sat Oct 12 22:06:42 1996
Return-Path: owner-cvs-sys
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id WAA05650
          for cvs-sys-outgoing; Sat, 12 Oct 1996 22:06:42 -0700 (PDT)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id WAA05639;
          Sat, 12 Oct 1996 22:06:34 -0700 (PDT)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.7.6/8.6.9) id PAA18023; Sun, 13 Oct 1996 15:01:33 +1000
Date: Sun, 13 Oct 1996 15:01:33 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199610130501.PAA18023@godzilla.zeta.org.au>
To: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org,
        cvs-sys@freefall.freebsd.org, dyson@freefall.freebsd.org
Subject: Re: cvs commit:  src/sys/i386/include pmap.h
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

>  Modified:    sys/i386/include  pmap.h
>  Log:
>  Pmap_resident_count was mistakenly removed from pmap.h, thereby
>  disabling the RSS listing in ps and ^T.  This commit re-inserts
>  the macro defn.

I hate ifders.

Please fix this properly by changing tty.c and kern_proc.c.  They
should call a machine-dependent function or macro that is required for
all machines.  Machine-dependent extern functions that are called from
machine-independent code should be prototyped a machine-independent
header, e.g., like cpu_switch().  Machine-dependent inline functions,
and macros have to defined in a machine-dependent header, e.g.,
like cpu_set_init().  (Hmm, 3 out of 4 of the cpu_* macros in
<machine/cpu.h> are not referenced.)

I have been wondering what to do about the same problem with
tcp_random18().  It's not really machine-dependent, so defining the
default for it in a machine-dependent place isn't quite right.

Bruce