From owner-freebsd-ports@FreeBSD.ORG  Wed Dec  3 21:00:12 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B8D1E1065677
	for <freebsd-ports@freebsd.org>; Wed,  3 Dec 2008 21:00:12 +0000 (UTC)
	(envelope-from lambert@lambertfam.org)
Received: from sysmon.tcworks.net (sysmon.tcworks.net [65.66.76.4])
	by mx1.freebsd.org (Postfix) with ESMTP id A61208FC0A
	for <freebsd-ports@freebsd.org>; Wed,  3 Dec 2008 21:00:08 +0000 (UTC)
	(envelope-from lambert@lambertfam.org)
Received: from sysmon.tcworks.net (localhost [127.0.0.1])
	by sysmon.tcworks.net (8.13.1/8.13.1) with ESMTP id mB3KMBYV016951
	for <freebsd-ports@freebsd.org>; Wed, 3 Dec 2008 14:22:11 -0600 (CST)
	(envelope-from lambert@lambertfam.org)
Received: (from lambert@localhost)
	by sysmon.tcworks.net (8.13.1/8.13.1/Submit) id mB3KMBij016950
	for freebsd-ports@freebsd.org; Wed, 3 Dec 2008 14:22:11 -0600 (CST)
	(envelope-from lambert@lambertfam.org)
X-Authentication-Warning: sysmon.tcworks.net: lambert set sender to
	lambert@lambertfam.org using -f
Date: Wed, 3 Dec 2008 14:22:11 -0600
From: Scott Lambert <lambert@lambertfam.org>
To: freebsd-ports@freebsd.org
Message-ID: <20081203202211.GA11883@sysmon.tcworks.net>
Mail-Followup-To: freebsd-ports@freebsd.org
References: <20081202192410.GA69963@sysmon.tcworks.net>
	<gh4pr0$p3b$1@hairball.ziemba.us>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <gh4pr0$p3b$1@hairball.ziemba.us>
User-Agent: Mutt/1.4.2.2i
Subject: Re: Proposal: mechanism for local patches
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Dec 2008 21:00:12 -0000

On Wed, Dec 03, 2008 at 02:10:40AM +0000, G. Paul Ziemba wrote:
> lambert@lambertfam.org (Scott Lambert) writes:
> 
> >How about something like WRKDIRPREFIX?
> 
> >Presumably the logic for dealing with that structure is already in
> >the system.  Maybe you could have USE_LOCAL_PATCHES boolean which
> >uses ${CATEGORY}/${PORTNAME}/files subdirs in WRKDIRPREFIX, or
> >LOCALPATCHDIRPREFIX if you want to keep your patches in CVS/SVN without
> >polluting the CVS/SVN working directory.
> 
> 
> I'm not sure I undersand - do you mean that you'd pick one of
> $(WRKDIRPREFIX)/${CATEGORY}/${PORTNAME}/files or
> $(LOCALPATCHDIRPREFIX)/${CATEGORY}/${PORTNAME}/files to get
> patches from, based on the state of USE_LOCAL_PATCHES? But I was
> hoping to augment $(WRKDIRPREFIX)/${CATEGORY}/${PORTNAME}/files
> instead of replacing it.

I meant them as implementation options.  The person doing the work to
add the functionality could choose which method to setup.  I did *not*
mean that both options should be setup in the Mk infrastructure and
leave the choice to the user.  But if the implementor wanted to do so,
that would be their choice.

Although, I suppose it could be setup such that only one new variable is
required, something like LOCALPATCHDIRPREFIX.  LOCALPATCHDIRPREFIX could
default to WRKDIRPREFIX.

-- 
Scott Lambert                    KC5MLE                       Unix SysAdmin
lambert@lambertfam.org