From owner-svn-src-all@freebsd.org Tue May 19 15:34:50 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 28D082DC550; Tue, 19 May 2020 15:34:50 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49RKgs6Kntz3T6K; Tue, 19 May 2020 15:34:49 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 04JFYlO6006760; Tue, 19 May 2020 08:34:47 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 04JFYlSQ006759; Tue, 19 May 2020 08:34:47 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202005191534.04JFYlSQ006759@gndrsh.dnsmgr.net> Subject: Re: svn commit: r361238 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs In-Reply-To: To: Kyle Evans Date: Tue, 19 May 2020 08:34:47 -0700 (PDT) CC: "Rodney W. Grimes" , src-committers , svn-src-all , svn-src-head Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 49RKgs6Kntz3T6K X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 15:34:50 -0000 > On Tue, May 19, 2020 at 10:27 AM Rodney W. Grimes > wrote: > > > > > On Tue, May 19, 2020 at 10:23 AM Rodney W. Grimes > > > wrote: > > > > > > > > > Author: kevans > > > > > Date: Tue May 19 02:41:05 2020 > > > > > New Revision: 361238 > > > > > URL: https://svnweb.freebsd.org/changeset/base/361238 > > > > > > > > > > Log: > > > > > zfs: reject read(2) of a dirfd with EISDIR > > > > > > > > > > This is independent of the recently-discussed global change, which is still > > > > > in review/discussion stage. > > > > > > > > > > This is effectively a measure for consistency in the ZFS world, where > > > > > FreeBSD was the only platform (as far as I could find) that allowed this. > > > > > What ZFS exposes is decidedly not useful for any real purposes, to > > > > > paraphrase (hopefully faithfully) jhb's findings when exploring this: > > > > > > > > > > The size of a directory in ZFS is the number of directory entries within. > > > > > When reading a directory, you would instead get the leading part of its raw > > > > > contents; the amount you get being dictated by the "size," i.e. number of > > > > > directory entries. There's decidedly (luckily) no stack disclosure happening > > > > > here, though the behavior is bizarre and almost certainly a historical > > > > > accident. > > > > > > > > > > This change has already been upstreamed to OpenZFS. > > > > > > > > Until the grep -d skip issue is addressed I object to this change as > > > > it is going to cause people who do grep with wildcards to see lots > > > > of errors that before where pretty much either silent (no match occured) > > > > or spit out a "binary file foo matches." > > > > > > > > > > That seems preferable to grepping random bytes that don't particularly > > > contain any strings? They'd never see "binary file foo matches" in > > > this case. > > > > The difference is you rarely get a hit, and now your gauranteed to > > get a hit on every single directory making grep * very noisy, where > > it was often silent or nearly silent before. > > > > As you noted in the review for the larger change, -d skip is a good > option for the people that don't like this. It probably makes sense as > a default, but then we'd be diverging from the other popular grep that > defaults to -d read and spews out EISDIR more often than not. Yet another thing I hate about Linux, thank you for adding it to FreeBSD :-) > > > > > > This isn't exactly divergent from the behavior they'd see with ZFS > > > anywhere else. > > > > It is extremly divergent from 42 years of behavior. > > > > I don't think ZFS has been implemented on FreeBSD for 42 years, and I > don't find this grep argument compelling enough to restore peoples' > ability to read the raw znode of a directory. The EISDIR behavior is what your changing, independent of file system(s) you have done so far. The fact the behavior is now different between UFS and ZFS is sic, IMHO. -- Rod Grimes rgrimes@freebsd.org