From owner-freebsd-stable@FreeBSD.ORG Fri Mar 12 19:21:49 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9350F106564A; Fri, 12 Mar 2010 19:21:49 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-fx0-f223.google.com (mail-fx0-f223.google.com [209.85.220.223]) by mx1.freebsd.org (Postfix) with ESMTP id EC92F8FC19; Fri, 12 Mar 2010 19:21:48 +0000 (UTC) Received: by fxm23 with SMTP id 23so1536810fxm.3 for ; Fri, 12 Mar 2010 11:21:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=lIAVvVUVjSvXGT5Ex3FrkSPRNgw4BX3Ua+CRW9NpNHM=; b=E+gO91+w/2ba66wtzx44rPkuZwUc4UqsxTBmE9uZh14kfUTfUZqfee5T7q475lxwX6 sDKSyL8I3LMvtOF3p8NU8RAyYKigJsvd3nBQBFFjwBQwlbDCWouaUEMFPZgpPAlQPbAq 5PxNXYFdGM4BcAaInxVzbukiLJNEJyjo/Wpyo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=Wpo1VyCyv5b1rp1NbF0EG0Lz0DUtrgQ7kD3xzuK0OfQ87FSml/GUtYlqLa3tuxtNgn VCFyykoFIchblMMuKzP2NkkzFF81gDoOBtzwKxLAFjvt4EhlIqT/1KDNWcO99IyUrl5W Vt0ZqxVuRPxa4+8zUy1pyvKdVOClH0qp1Zt3g= Received: by 10.87.47.1 with SMTP id z1mr2235090fgj.74.1268421707927; Fri, 12 Mar 2010 11:21:47 -0800 (PST) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id e11sm1990831fga.16.2010.03.12.11.21.45 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 12 Mar 2010 11:21:46 -0800 (PST) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Fri, 12 Mar 2010 11:21:44 -0800 From: Pyun YongHyeon Date: Fri, 12 Mar 2010 11:21:44 -0800 To: Pierre Beyssac Message-ID: <20100312192144.GL16314@michelle.cdnetworks.com> References: <20100312121409.GA79294@fasterix.frmug.org> <20100312174655.GG16314@michelle.cdnetworks.com> <20100312182134.GA90606@fasterix.frmug.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="1UWUbFP1cBYEclgG" Content-Disposition: inline In-Reply-To: <20100312182134.GA90606@fasterix.frmug.org> User-Agent: Mutt/1.4.2.3i Cc: freebsd-stable@freebsd.org Subject: Re: 8-STABLE interrupt storm on atapci(?), Dell Inspiron 580 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2010 19:21:49 -0000 --1UWUbFP1cBYEclgG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 12, 2010 at 07:21:34PM +0100, Pierre Beyssac wrote: > On Fri, Mar 12, 2010 at 09:46:55AM -0800, Pyun YongHyeon wrote: > > This is not related with your interrupt storm issue but something > > is wrong here. I think brgphy(4) should be used for bge(4). Have no > > idea why the OUI has a different value. > > Would you try attached patch and let me know whether brgphy(4) > > get attached to the PHY? > > It sort of works (see attached dmesg) but not quite correctly, the > ethernet link takes an awful lot of time to negotiate (> 10s) and > it negotiates 10 Mbps instead of 100 Mbps previously. > > The message "Unrecognized OUI for PHY!" seems to indicate something's > amiss, maybe I should regenerate some file(s) after applying your > patches? No, it seems there is other issue in brgphy(4). I noticed brgphy(4) blindly try to set jumbo frame related registers. I guess the PHY may not have the register. Back out previous patch and try this one. --1UWUbFP1cBYEclgG Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="BCM57780.diff2" Index: sys/dev/mii/miidevs =================================================================== --- sys/dev/mii/miidevs (revision 205052) +++ sys/dev/mii/miidevs (working copy) @@ -81,6 +81,7 @@ oui xxALTIMA 0x000895 Altima Communications oui xxBROADCOM 0x000818 Broadcom Corporation oui xxBROADCOM_ALT1 0x0050ef Broadcom Corporation +oui xxBROADCOM_ALT2 0x00d897 Broadcom Corporation oui xxICS 0x00057d Integrated Circuit Systems oui xxSEEQ 0x0005be Seeq oui xxSIS 0x000760 Silicon Integrated Systems @@ -150,6 +151,7 @@ model xxBROADCOM_ALT1 BCM5784 0x003a BCM5784 10/100/1000baseTX PHY model xxBROADCOM_ALT1 BCM5709C 0x003c BCM5709C 10/100/1000baseTX PHY model xxBROADCOM_ALT1 BCM5761 0x003d BCM5761 10/100/1000baseTX PHY +model xxBROADCOM_ALT2 BCM57780 0x0019 BCM57780 10/100/1000baseTX PHY model BROADCOM2 BCM5906 0x0004 BCM5906 10/100baseTX PHY /* Cicada Semiconductor PHYs (now owned by Vitesse?) */ Index: sys/dev/mii/brgphy.c =================================================================== --- sys/dev/mii/brgphy.c (revision 205052) +++ sys/dev/mii/brgphy.c (working copy) @@ -139,6 +139,7 @@ MII_PHY_DESC(xxBROADCOM_ALT1, BCM5784), MII_PHY_DESC(xxBROADCOM_ALT1, BCM5709C), MII_PHY_DESC(xxBROADCOM_ALT1, BCM5761), + MII_PHY_DESC(xxBROADCOM_ALT2, BCM57780), MII_PHY_DESC(BROADCOM2, BCM5906), MII_PHY_END }; @@ -213,6 +214,7 @@ switch (bsc->mii_oui) { case MII_OUI_BROADCOM: case MII_OUI_BROADCOM2: + case MII_OUI_xxBROADCOM_ALT2: break; case MII_OUI_xxBROADCOM: switch (bsc->mii_model) { @@ -1021,7 +1023,8 @@ if (bge_sc->bge_flags & BGE_FLAG_JITTER_BUG) brgphy_fixup_jitter_bug(sc); - brgphy_jumbo_settings(sc, ifp->if_mtu); + if (bge_sc->bge_flags & BGE_FLAG_JUMBO) + brgphy_jumbo_settings(sc, ifp->if_mtu); if (bge_sc->bge_flags & BGE_FLAG_WIRESPEED) brgphy_ethernet_wirespeed(sc); --1UWUbFP1cBYEclgG--