From owner-cvs-all Thu Jan 10 19:36:20 2002 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id F31D137B405; Thu, 10 Jan 2002 19:35:32 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 7376A14C53; Fri, 11 Jan 2002 04:35:31 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Marcel Moolenaar Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_ioctl.c References: <200201100536.g0A5aao01807@freefall.freebsd.org> <20020110191209.A318@dhcp01.pn.xcllnt.net> From: Dag-Erling Smorgrav Date: 11 Jan 2002 04:35:30 +0100 In-Reply-To: <20020110191209.A318@dhcp01.pn.xcllnt.net> Message-ID: Lines: 30 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Marcel Moolenaar writes: > It is correct WRT the translations done the opposite direction. If > this is incorrect, the other fixes are also incorrect. Either they > both go, or they all stay. Since you didn't object to the first > round of fixes, I don't see how you can object to this one. I would have if I had noticed them, but I was too busy at the time. I have already provided reasons why both sets of changes are incorrect. So please back revisions 1.77 and 1.79 out. > Thirdly, you did not consult me when you made the changes, as I was > at that time the official *active* maintainer of the Linuxulator. Yes, I did. You reviewed my patch. Do you want a copy of my mail archive? > So, all considered, I urge you to be constructive and provide good > explanations as to why you think it is broken and I'm sure we can > sort it all out. In the mean time the only conclusive evidence I > have is that it fixes a bug. I have yet to see a report that it > breaks something else. 1) This numbering scheme allows interfaces to move. 2) Your commit breaks linprocfs. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message