From owner-svn-src-head@freebsd.org Fri Mar 13 00:35:02 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B53A26FE8A; Fri, 13 Mar 2020 00:35:02 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48dmtZ0Gb4z4Swy; Fri, 13 Mar 2020 00:35:01 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-qv1-f68.google.com with SMTP id ca9so3700074qvb.9; Thu, 12 Mar 2020 17:35:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DU3CyG5pQIuCTJVq6jcq9Jz8YalIjbbpm8LEeZFKlzk=; b=O3e+dfELmFESh1Ygjc+5n8KDvvnfhnE5B+8D3HkyxSUV/fI3R5PHXOpjFKMLDHlahO G2BJmZ3U0vuZqEqHKW4NGX5VTmV2Eue4LuDjhvRnKKWHmm2KvO05h8EZZOiH+/H67z7n /FopAoCJR/DzSJzOdHPTdW2AdY9wEtLw9bPoCJezJyu3msgFWu9JNORt7rcXnXPnX4Em Zqf6b0LaqOKWaauqV9IbJ5r9AYT4vf73MjfFtwtctIuERe7a6YPNNblWhX6LxZoO4p96 0zuFDCvvqVFK8gx57qDQIGovgqRZK5rdwgB36H1t24Vly3YAU7dLdJKzUP1SzT+V0Dvp LYPg== X-Gm-Message-State: ANhLgQ2PkjPxVDApnQW5NOo5TpLLMQpdYZppGs92eNB7hPqYAHMimUDW s78dieDkAOMiyXov7hbZ9Hs1a6bg X-Google-Smtp-Source: ADFU+vv7D0EP6PGl4FcR1xpYt0k2Pbx3eUn2AM0XKRBXqt8Ankm8a8h7scwSgxqd3lfcqTs78eIZlw== X-Received: by 2002:a0c:a998:: with SMTP id a24mr9844467qvb.141.1584059700627; Thu, 12 Mar 2020 17:35:00 -0700 (PDT) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com. [209.85.222.170]) by smtp.gmail.com with ESMTPSA id m27sm4707715qtf.80.2020.03.12.17.35.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2020 17:35:00 -0700 (PDT) Received: by mail-qk1-f170.google.com with SMTP id d8so9698834qka.2; Thu, 12 Mar 2020 17:35:00 -0700 (PDT) X-Received: by 2002:ae9:de06:: with SMTP id s6mr10437405qkf.34.1584059700052; Thu, 12 Mar 2020 17:35:00 -0700 (PDT) MIME-Version: 1.0 References: <202003122304.02CN4fXO062077@repo.freebsd.org> In-Reply-To: <202003122304.02CN4fXO062077@repo.freebsd.org> From: Kyle Evans Date: Thu, 12 Mar 2020 19:34:48 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r358923 - in head: lib/libpmcstat usr.sbin/pmcstat To: Ryan Moeller Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 48dmtZ0Gb4z4Swy X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2020 00:35:02 -0000 On Thu, Mar 12, 2020 at 6:05 PM Ryan Moeller wrote: > > Author: freqlabs > Date: Thu Mar 12 23:04:40 2020 > New Revision: 358923 > URL: https://svnweb.freebsd.org/changeset/base/358923 > > Log: > libpmcstat: Try /boot/modules if module not found > > Modules from ports/pkg are commonly installed to /boot/modules rather than to > the same directory the kernel resides in. Look there if a module is not found > next to the kernel. > > Submitted by: mmacy > Reported by: Nick Principe > Approved by: mmacy (mentor) > MFC after: 2 weeks > Sponsored by: iXsystems, Inc. > It's unclear from the context- is there any particular reason this can't instead using sysctl kern.module_path and accept a semicolon delimited list of directories for -k (maybe calling it -k kernelpath instead)? Thanks, Kyle Evans