From owner-svn-src-all@FreeBSD.ORG Thu Jan 29 21:38:57 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6653EE6C; Thu, 29 Jan 2015 21:38:57 +0000 (UTC) Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3AFB7CBA; Thu, 29 Jan 2015 21:38:56 +0000 (UTC) Received: from [69.38.252.84] (port=35350 helo=[172.16.19.1]) by vps.hungerhost.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.82) (envelope-from ) id 1YGwne-0002D1-81; Thu, 29 Jan 2015 16:38:55 -0500 From: "George Neville-Neil" To: "Andrew Turner" Subject: Re: svn commit: r277835 - in head: lib/libpmc sys/arm/arm sys/arm/include sys/arm/ti sys/conf sys/dev/hwpmc sys/sys Date: Thu, 29 Jan 2015 16:38:43 -0500 Message-ID: In-Reply-To: <20150128192719.2baf6145@bender> References: <201501281608.t0SG88gs009253@svn.freebsd.org> <1422462903.15718.60.camel@freebsd.org> <20150128183913.GA44243@bsdpad.com> <20150128192719.2baf6145@bender> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Mailer: MailMate (1.8r5035) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - neville-neil.com X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id: gnn@neville-neil.com Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Ruslan Bukin , src-committers@freebsd.org, Ian Lepore X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2015 21:38:57 -0000 On 28 Jan 2015, at 14:27, Andrew Turner wrote: > On Wed, 28 Jan 2015 18:39:13 +0000 > Ruslan Bukin wrote: >> On Wed, Jan 28, 2015 at 09:35:03AM -0700, Ian Lepore wrote: >>> Just from a quick glance at the part that wasn't truncated, I >>> notice all the inline asm stuff is wrong -- it duplicates what's >>> already available in cpu-v6.h. >>> >> >> I had a conversation with Andrew this morning, he pointed me out >> those defines in cpu-v6.h, but we agreed those are optional stuff. >> I.e. duplicates != wrong. I'll fix that. Thanks > > It would be useful to use them, but this will need Makefile changes as > some of these defines are only available when __ARM_ARCH > 6 which may > not be true in userland. If we do make these changes we then need to > make sure that none of the code on the file built as ARMv7 is run on > an > ARMv6 as the compiler may choose to use invalid instructions on v6. I gather what is referred to here as defines are the macros that Ian (I think) added for access to the pmc and other fancy registers? I see that the hwpmc code has asm directly in it. Best, George