From owner-svn-src-head@freebsd.org Fri Aug 12 21:25:19 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B866BB8884; Fri, 12 Aug 2016 21:25:19 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qt0-x229.google.com (mail-qt0-x229.google.com [IPv6:2607:f8b0:400d:c0d::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0635F1190; Fri, 12 Aug 2016 21:25:19 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qt0-x229.google.com with SMTP id u25so18518696qtb.1; Fri, 12 Aug 2016 14:25:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SOX2rWsTpRe6HrVv2mpwHHydDqMy2IwFddhwSNB9fqc=; b=Sg0+kklZ6QePWBiGzGw+wS8JSpw++/zIrq/KlvcpBNsCtft9C/vHU+mQR5TzBq6Rg7 fVuYX4BPTc7/p2cG+WlzuSjitr1AW5xDe3p3iOJgG6ZFGNg1j/gQ+0t2aYStpWIbp+ib lloQANZFDb4mNS8l2cB2BdVrteP1pie/AhWodCC32Z2d5xOZMs2UQhXxTizXyrRo8yUB UX6emOZeEHq+5CfhZhxdH5f16g5lb0QdaK3LuZcWZMZ/wk2A5/Qez/OLrvaE0hva7n12 cToSNQr2Q1arJQOs5VwD+zuz80W4fMuADhMLr+q8ZXB67tI1ZLUAeZO1KlyNlClE55WM e+lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SOX2rWsTpRe6HrVv2mpwHHydDqMy2IwFddhwSNB9fqc=; b=jX1IsJBFUujqn6wF+9TPO6ASUlZDupYjK/USo7muTUd+OJgDNlJzDvugrk4qgMvWBy TA89xRL8D4hOfmvRPU8b0fYpzoUF5uhJdahzUgC1TJzc3ADHSNnWRmBSsViznsnZ1XPp 07+yp55eu9jwkyVW6JOcoxY2kGUI1qTOu0WFuoN5QER/ZU13tTROnFt4wdMssNaDZ15E dFwErO3KbIxXun7/0wBCORn1/W13ipRaWZdxyyqUw/TpgE6QxmjBLieNBLTVAPaT6BwN swphJ1GwP6PE4pUfeQCbwzLlp+qCFEGZmQJa9Y7ZR9s/cDu5jOzuKqMSMRkNbE7QU9n3 mAnQ== X-Gm-Message-State: AEkooutOc/GA02WyaN4O8HtZmlZqX/dLdrk5p9lWWDBO3S2U3KaZAyAHywW4R5prlMTLY/OsOnRXC9MCa7oqJA== X-Received: by 10.237.59.79 with SMTP id q15mr18940337qte.77.1471037117572; Fri, 12 Aug 2016 14:25:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.182.70 with HTTP; Fri, 12 Aug 2016 14:25:17 -0700 (PDT) In-Reply-To: <20160812183636.GP83214@kib.kiev.ua> References: <201608121829.u7CITCIu059447@repo.freebsd.org> <35B0B56E-A536-4A07-B397-7E5ABAB4CB34@gmail.com> <20160812183636.GP83214@kib.kiev.ua> From: Ngie Cooper Date: Fri, 12 Aug 2016 14:25:17 -0700 Message-ID: Subject: Re: svn commit: r304011 - head/libexec/rtld-elf To: Konstantin Belousov Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2016 21:25:19 -0000 On Fri, Aug 12, 2016 at 11:36 AM, Konstantin Belousov wrote: ... > Because the API is unusable. It causes full queue iteration when the object > is NULL, i.e. at the end of the queue, instead of doing nothing. It would have been nice if this had been documented in the commit message instead of leaving the reader to guess.. Thank you for the explanation -- I really appreciate it! -Ngie