From owner-cvs-all Thu Apr 18 9: 5: 4 2002 Delivered-To: cvs-all@freebsd.org Received: from sdns.kv.ukrtel.net (sdns.kv.ukrtel.net [195.5.27.246]) by hub.freebsd.org (Postfix) with ESMTP id E777F37B416; Thu, 18 Apr 2002 09:04:53 -0700 (PDT) Received: from vega.vega.com (195.5.51.243 [195.5.51.243]) by sdns.kv.ukrtel.net with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21) id JFW89BZ0; Thu, 18 Apr 2002 19:06:27 +0300 Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vega.vega.com (8.11.6/8.11.3) with ESMTP id g3IG5vx49056; Thu, 18 Apr 2002 19:05:57 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) Message-ID: <3CBEEF11.42410689@FreeBSD.org> Date: Thu, 18 Apr 2002 19:06:41 +0300 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U) X-Accept-Language: en,uk,ru MIME-Version: 1.0 To: Ruslan Ermilov Cc: Gordon Tetlow , portmgr@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: [PATCH] bsd.port.mk is broken References: <200204171349.g3HDnTV73622@freefall.freebsd.org> <20020418080234.GF98788@sunbay.com> <3CBED91C.3ED57B68@FreeBSD.org> <20020418152443.GB79334@sunbay.com> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Ruslan Ermilov wrote: [snip] > > > > > > > > This broke any port that uses HAS_CONFIGURE (or USE_CONFIGURE, or > > > > whatever), which adds into the environment INSTALL="/usr/bin/install -c -o > > > > ${BINOWN} -g ${BINGRP}" which are now undefined now that sys.mk no longer > > > > includes bsd.own.mk > > > > > > > Yeah, it did. Could someone from portmgr@ please commit this patch? > > > > > > %%% > > > Index: bsd.port.mk > > > =================================================================== > > > RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v > > > retrieving revision 1.409 > > > diff -u -r1.409 bsd.port.mk > > > --- bsd.port.mk 4 Apr 2002 10:06:00 -0000 1.409 > > > +++ bsd.port.mk 18 Apr 2002 07:59:17 -0000 > > > @@ -628,6 +628,9 @@ > > > PORTOBJFORMAT!= test -x /usr/bin/objformat && /usr/bin/objformat || echo aout > > > .endif > > > > > > +# Get system defaults. > > > +.include > > > + > > > MASTERDIR?= ${.CURDIR} > > > > > > # If they exist, include Makefile.inc, then architecture/operating > > > %%% > > > > Will it affect 4-STABLE? > > > Only after I MFC this stuff. Mmm, looks like you misunderstood my question or I misformulated it. What I meant is: whether or not bsd.port.mk with your change will have any problems on a -STABLE systems without your bsd.xxx.mk stuff MFCed? As you might know, ports tree isn't branched, so we have to ensure that *the same* bsd.port.mk does work both on -stable and -current. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message