From owner-p4-projects Sun Dec 1 19:46:38 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 0764B37B404; Sun, 1 Dec 2002 19:46:36 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A6E0C37B401 for ; Sun, 1 Dec 2002 19:46:35 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 852DD43EBE for ; Sun, 1 Dec 2002 19:46:34 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.6/8.12.3) with ESMTP id gB23kRH2000583; Sun, 1 Dec 2002 20:46:28 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 01 Dec 2002 20:46:07 -0700 (MST) Message-Id: <20021201.204607.91990973.imp@bsdimp.com> To: marcel@xcllnt.net Cc: dfr@nlsystems.com, perforce@freebsd.org Subject: Re: PERFORCE change 21719 for review From: "M. Warner Losh" In-Reply-To: <20021201185017.GA4331@dhcp01.pn.xcllnt.net> References: <200211302059.gAUKxkZZ077084@repoman.freebsd.org> <200212011011.33999.dfr@nlsystems.com> <20021201185017.GA4331@dhcp01.pn.xcllnt.net> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20021201185017.GA4331@dhcp01.pn.xcllnt.net> Marcel Moolenaar writes: : On Sun, Dec 01, 2002 at 10:11:33AM +0000, Doug Rabson wrote: : > On Saturday 30 November 2002 8:59 pm, Marcel Moolenaar wrote: : > > http://perforce.freebsd.org/chv.cgi?CH=21719 : > > : > > Change 21719 by marcel@marcel_nfs on 2002/11/30 12:58:56 : > > : > > Remove isa and BOOTP_*. : > > Comment out sio. : > > : > > The UART hardware is not supported by the sio driver. It is : > > probed with some hackery, but the sio driver is in essense : > > too ISA/i386 oriented (pretty much like fb/vga/sc). : > : > In what way? : : It assumes the UART uses I/O. The isa_irq_pending() function is also : an example of an ISA dependency. The latter does not prevent the sio : driver from working, but it does cause an annoying message at boot. There's no ISA bus at all, or there's no ISA expansion slots? : > The sio driver itself just assumes that it can use : > bus_space to access a standard 16550 uart or similar. The bus : > attachment code (sio_isa, sio_pccard, sio_ebus etc.) contains any code : > which is bus-related. This driver works quite well on five different : > busses - what does the HP machine do that is different? : : For one, it hasn't got any ISA busses. Secondly, the Diva comm board : is memory mapped. In sioprobe() we assume I/O. It's also a multiport : board and we also don't seem to have the framework yet to just tell : it the characteristics of this board as the Linux driver has. It would be trivial to hack the sio driver to do memory mapped I/O, but that's more in the realm of the puc driver. puc handles multi-ported boards and uses a lookup table it has to tell the sio driver what kind of stuff to do. These are nits, not major reasons to avoid sio. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message