From nobody Thu Nov 27 00:19:16 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dGxr96qlpz6HrWN for ; Thu, 27 Nov 2025 00:19:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dGxr96JGQz41lc for ; Thu, 27 Nov 2025 00:19:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764202761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/3Te8U4e4bQL0z4xuhwXJp/VaC6pxtYlpzEu16CZb4M=; b=MU7Uww1MUIeReHq/WMqDia+tHWMGbXgyJbl+Tdm8J7BlWh2g5N5Exc/t2SMXQI5YTlrS97 NOg3nCzJ3SV9G3fkDcyLl4JLCSnLHeythPIC+EH7zkJryXNy4HsMPtQwEkBNEJvdsevWD+ CJ1jdQy/RMZTqzVVuitELbmUjVS6jQDBpNUi8eTF8Zl29y82cNnesQx7YCTTXaV76xkK5B 4AQnDIMnvT3SgFGw/MKYOt/T7CJbkHGgSiUeH1KQxGjZrZDR60ZGQfD1whzy/N8osqFFSy 1tfsu90VDl6Ckxx5n7QHUVP4fBpNrRD1B4uno8eDhFgnlQa/vMLLDUp4rK5h4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764202761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/3Te8U4e4bQL0z4xuhwXJp/VaC6pxtYlpzEu16CZb4M=; b=SuxmhEL2hidLHF3ObzdbzsMZ6aLVZZijCbuWJ6BCe2FhHrnp2sGwOn1B6Kd0hvsEEQI0LY 4eaTUjC7yMjzCDKTN/l2kE4hdvrOfYMD0CfCczaSI8gqpawMV4dBVeGyzMfEB7YTg8/r3s mYms6okoWb9Q6jysP56rKfvZRSEAJPYW25LoA9gVKfXrHM3mRKHr24LJf8o9xqhUby8pfd eO1GrNNeUvM7Ja1osozrK2FmM0Ddewjyh7s+uG/srb/0I3HnPq8l3xpfYFuf6aSJ+6MsJL xNCItXZY3n/C/LJdZaWt4iLzemQh12rTYEmHslPLDmQKkQUhhBhOEqJ3gSs7dg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764202761; a=rsa-sha256; cv=none; b=NjlyOHm8iAR3SH/Mtl/QGjYjtnRbBHkdkPppHXWsU26/ocSnCglaXUSttuaHVI6ev242fb b5oxYj2SeBrydUFR8ZjG9oVN5ROqDoZc4nesm+ne22H0rCdaQl8RK6F0y7IWxKmLKr3IYs NRoaLX7yglQgN6gKvfZhxULUDu4YhOR/4Oj/ntgrd6fxW22siaDjH0pK8BaeRwVXBu2kB7 ldT7sa0gpruxsqHL/3hBCmO/VXJEJy8W7vsAWhtUtt+Q/wkaQf6dDf+ZWUIpx7JukNyMt2 3V3YXZ1pvm3kLHNEAqjiWVEkcn79upy0b2MMOEAEPMspQIZGj7Vuv37FiBCeBw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dGxr95vwRz17r9 for ; Thu, 27 Nov 2025 00:19:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id e067 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 27 Nov 2025 00:19:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 5198c3221003 - main - vt: Allow VT_SETMODE with frsig=0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5198c32210039d8dc92554647384eee75688848c Auto-Submitted: auto-generated Date: Thu, 27 Nov 2025 00:19:16 +0000 Message-Id: <69279904.e067.1bd856b9@gitrepo.freebsd.org> The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=5198c32210039d8dc92554647384eee75688848c commit 5198c32210039d8dc92554647384eee75688848c Author: Ed Maste AuthorDate: 2025-09-30 19:39:34 +0000 Commit: Ed Maste CommitDate: 2025-11-27 00:19:04 +0000 vt: Allow VT_SETMODE with frsig=0 Linux does not check that any of the signals in vt_mode VT_SETMODE ioctl (relsig, acqsig, frsig) are valid, but FreeBSD required that all three are valid. frsig is unusued in both Linux and FreeBSD, and software typically leaves it unset. To improve portability, allow frsig to be set to zero. PR: 289812 Reported by: Dušan Gvozdenović Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52835 --- sys/dev/vt/vt_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/vt/vt_core.c b/sys/dev/vt/vt_core.c index a1376be954ee..5e8f7b1d0bb7 100644 --- a/sys/dev/vt/vt_core.c +++ b/sys/dev/vt/vt_core.c @@ -3046,9 +3046,9 @@ skip_thunk: DPRINTF(5, "reset WAIT_ACQ, "); return (0); } else if (mode->mode == VT_PROCESS) { - if (!ISSIGVALID(mode->relsig) || - !ISSIGVALID(mode->acqsig) || - !ISSIGVALID(mode->frsig)) { + if (!(ISSIGVALID(mode->relsig) && + ISSIGVALID(mode->acqsig) && + (mode->frsig == 0 || ISSIGVALID(mode->frsig)))) { DPRINTF(5, "error EINVAL\n"); return (EINVAL); }