From owner-svn-ports-all@freebsd.org Tue Apr 25 11:15:23 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0FA21D4F652; Tue, 25 Apr 2017 11:15:23 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id BB59D872; Tue, 25 Apr 2017 11:15:22 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 0F587BDCDC; Tue, 25 Apr 2017 13:15:21 +0200 (CEST) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 01F65BDCC8; Tue, 25 Apr 2017 13:15:19 +0200 (CEST) Subject: Re: svn commit: r437533 - head/security/p5-Crypt-LE To: Kurt Jaeger , Dag-Erling Sm??rgrav Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201704020840.v328eDhD064705@repo.freebsd.org> <86o9vloshz.fsf@desk.des.no> <20170425073836.GY70553@fc.opsec.eu> From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: <03566f47-daa8-2841-233b-b09f6282ad51@FreeBSD.org> Date: Tue, 25 Apr 2017 13:15:17 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <20170425073836.GY70553@fc.opsec.eu> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QaJkCPsjJxQuRxuatKqEo1Senh6bHEADj" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 11:15:23 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QaJkCPsjJxQuRxuatKqEo1Senh6bHEADj Content-Type: multipart/mixed; boundary="5FkEjImcnauWWpAL1DeExQPD2tm7C22Uu"; protected-headers="v1" From: Mathieu Arnold To: Kurt Jaeger , Dag-Erling Sm??rgrav Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <03566f47-daa8-2841-233b-b09f6282ad51@FreeBSD.org> Subject: Re: svn commit: r437533 - head/security/p5-Crypt-LE References: <201704020840.v328eDhD064705@repo.freebsd.org> <86o9vloshz.fsf@desk.des.no> <20170425073836.GY70553@fc.opsec.eu> In-Reply-To: <20170425073836.GY70553@fc.opsec.eu> --5FkEjImcnauWWpAL1DeExQPD2tm7C22Uu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: fr Le 25/04/2017 =C3=A0 09:38, Kurt Jaeger a =C3=A9crit : > Hi! > >>> RUN_DEPENDS=3D p5-Crypt-Format>=3D0:security/p5-Crypt-Format \ >>> - p5-Crypt-OpenSSL-PKCS10>=3D0:security/p5-Crypt-OpenSSL-PKCS10 \ >>> - p5-Crypt-PKCS10>=3D0:security/p5-Crypt-PKCS10 \ >>> p5-IO-Socket-SSL>=3D0:security/p5-IO-Socket-SSL \ >>> p5-JSON-MaybeXS>=3D0:converters/p5-JSON-MaybeXS \ >>> p5-Log-Log4perl>=3D0:devel/p5-Log-Log4perl \ >> Why did you remove those dependencies? > I've misread the Changelog, where it says: > > - Dropped non-portable Crypt::OpenSSL::PKCS10 dependency. > - Removed Crypt:::PKCS10 dependency. > >> Why are you maintaining a port that you can't even be bothered to test= >> before committing updates? > I do not actively use it, so I have no test cases right now. Well, you may not have a test case, but "make test" does work for all Perl ports by default (or, well, not work in that case) (from a testport -i prompt): root@10amd64-ports:/usr/ports/security/p5-Crypt-LE # make test =3D=3D=3D> Testing for p5-Crypt-LE-0.22 PERL_DL_NONLAZY=3D1 "/usr/local/bin/perl5.24.1" "-MExtUtils::Command::MM"= "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00-load.t ...... 1/? Bailout called. Further testing stopped: # Failed test 'use Crypt::LE;' # at t/00-load.t line 10. # Tried to use 'Crypt::LE'. # Error: Can't locate Crypt/OpenSSL/RSA.pm in @INC (you may need to install the Crypt::OpenSSL::RSA module) (@INC contains: /wrkdirs/usr/ports/security/p5-Crypt-LE/work/Crypt-LE-0.22/blib/lib /wrkdirs/usr/ports/security/p5-Crypt-LE/work/Crypt-LE-0.22/blib/arch /usr/local/lib/perl5/site_perl/mach/5.24 /usr/local/lib/perl5/site_perl /usr/local/lib/perl5/5.24/mach /usr/local/lib/perl5/5.24) at /wrkdirs/usr/ports/security/p5-Crypt-LE/work/Crypt-LE-0.22/blib/lib/Crypt= /LE.pm line 123. # BEGIN failed--compilation aborted at /wrkdirs/usr/ports/security/p5-Crypt-LE/work/Crypt-LE-0.22/blib/lib/Crypt= /LE.pm line 123. # Compilation failed in require at t/00-load.t line 10. # BEGIN failed--compilation aborted at t/00-load.t line 10. --=20 Mathieu Arnold --5FkEjImcnauWWpAL1DeExQPD2tm7C22Uu-- --QaJkCPsjJxQuRxuatKqEo1Senh6bHEADj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJY/y/GXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IbOMP/3LP+ioe91fGXkBO8poC/Y0g 3sn6HGtlnpSiLTzGsEVhV3Eyuklt5p+a3pAASq6ak1c/rLmnQTGvqusPG72QQ11q 1czlLc3C5qPSoX/JHfQqICMPK2W/oR39mUmrHA9tv+DQqvkqNbTpSszHUKg7OcC2 5zW/MHDSBoI3DWqMBIm/QFWV0uj2daADGfGtF31qyn5B0Tvyxf8NBpZHCJ1PqtNY 05pL53kSf5wPRwhwuNk97S04heQQ/4ew1hjeNhM7eWiurLh63gygzb+GT30/n2Fv 0lUy0WcqRZPu2D3cN+o8YM7OJJTvardJkQxkkG1yyxjnLBHVq6+qYleWl/wot8df zEmK8Wu7Eo9gaBhqwaprn7Tn89jUA+mAKA8gVRM0pXOiHnzR9gn9BCCWEVfZ4iS2 sKAa01PdtxU1n939eR7Xe1eKKJ04RBXdPA+X48D1FUyoByR3BngXos9vAWkKD8zt sNdF25Kyn0yz8nZ9Md0LEWxsgZvZ9qurQi6bEl6knfkFqWpKH+W5Iu+VFNGT59Bk fyMAyIFNxXdzOmMuQatNU5UYSiki59nAvkftUGrccodjTPggOMYhspri9QWHnvQY TxxYi3z4c87lKQov4d/69ya0xeeB2KCkybxThw9bVk+J8hqt0/T3Gg0/GpxLpD2x fIXxlVXhMAbuHLNtZiz1 =t4Yd -----END PGP SIGNATURE----- --QaJkCPsjJxQuRxuatKqEo1Senh6bHEADj--