From owner-freebsd-fs@FreeBSD.ORG  Wed Mar 16 15:03:29 2011
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E8B7E106566C;
	Wed, 16 Mar 2011 15:03:29 +0000 (UTC)
	(envelope-from lists@yamagi.org)
Received: from mail.yamagi.overkill.yamagi.org (unknown
	[IPv6:2a01:4f8:121:2102:1::7])
	by mx1.freebsd.org (Postfix) with ESMTP id 7E8CB8FC12;
	Wed, 16 Mar 2011 15:03:29 +0000 (UTC)
Received: from saya.home.yamagi.org (unknown
	[IPv6:2001:5c0:150f:8700:21b:21ff:fe07:b562])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.yamagi.overkill.yamagi.org (Postfix) with ESMTPSA id
	1CC7D16663D1; Wed, 16 Mar 2011 16:03:27 +0100 (CET)
Date: Wed, 16 Mar 2011 16:03:22 +0100 (CET)
From: Yamagi Burmeister <lists@yamagi.org>
X-X-Sender: yamagi@saya.home.yamagi.org
To: Kostik Belousov <kostikbel@gmail.com>
In-Reply-To: <20110316110924.GN78089@deviant.kiev.zoral.com.ua>
Message-ID: <alpine.BSF.2.00.1103161559260.3138@saya.home.yamagi.org>
References: <alpine.BSF.2.00.1103160925050.4245@saya.home.yamagi.org>
	<20110316110924.GN78089@deviant.kiev.zoral.com.ua>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-fs@freebsd.org, mckusick@freebsd.org
Subject: Re: Snapshots are never freed on at least 8.1 and 8.2
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Mar 2011 15:03:30 -0000

On Wed, 16 Mar 2011, Kostik Belousov wrote:

> On Wed, Mar 16, 2011 at 09:27:04AM +0100, Yamagi Burmeister wrote:
>> Hello,
>> I'm not sure if this is a bug or the expected behavior but it seems quit
>> strange. On at least FreeBSD 8.1 and 8.2 UFS2 snapshots are never freed
>> while the filesystem is mounted. Therefor you have to remount every 20
>> snapshots which is quiet a pain when using "dump -L" or similar things
>> via cron.
> ...
>
> Yes, very interesting. It seems that ffs_snapgone() is never called.
> How did our build system mutated over the time so that FFS is no longer
> defined, I do not know and do not much want to track.

The patch is working as espected. I've done a quick test with GENERIC
and one with a seperatly build module. Thanks. :)

-- 
Homepage:     www.yamagi.org
Jabber:       yamagi@yamagi.org
GnuPG/GPG:    0xEFBCCBCB