From owner-svn-src-all@freebsd.org Wed Sep 25 23:01:37 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0B0F9135D12; Wed, 25 Sep 2019 23:01:37 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46dtpm5Flvz4gQf; Wed, 25 Sep 2019 23:01:36 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f53.google.com with SMTP id b136so1380900iof.3; Wed, 25 Sep 2019 16:01:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UwEmUTJdH8AT5fyYLnltqm3e05I3SYIBg6sa6x1BowU=; b=WK2tepFqt8A+RtRrMA9KaSQEUjT52qf1vC202fIk+bOkXCJaGPbfVLF6gnMGh1bny8 T69H1IpuF16/cP89aZSvp5ZosMCwwbEKWRGPZhj+HcO+8Yxc/nmGrqLe0aVKrq9EZAAz CXTzVeYZP6xbS9Wh26Tjwpe97hHsF7krlNu8q/oYjuAWOad515k2a25IbbCo6kF2d1iG kAWoAlPWyhWwW6P4WSDmyPumsyMzHK+OlpXvB183/E9yBZUsM2E2vGvEoYAQs+97y6BM Asu5Aj8YSps1jVZiS4OO/DE0EDQwCXQn4+KEI8GgN0RO7jR7+miNUO8OocB0lUw9akZJ 09lQ== X-Gm-Message-State: APjAAAXWZL9d6rjKLw8P/nJgk65HSEVX4AFabkFroeqpuChJZk+fAf8f Wn5+WiwAzJDyGvzrfZyLoNyiw8GiANmZYurbLDJh7w== X-Google-Smtp-Source: APXvYqxLLbmRMJ8d/2j0TJLP9iA0kOr6Ff3pEy6Iz3d9EDEc45dxkyD0U1lswjw4e9x7/GvdSYtOgSLu6z2/6OWwhmA= X-Received: by 2002:a92:8cd9:: with SMTP id s86mr123299ill.120.1569452494371; Wed, 25 Sep 2019 16:01:34 -0700 (PDT) MIME-Version: 1.0 References: <201909242036.x8OKahnv021758@repo.freebsd.org> <20190925070207.Y3271@besplex.bde.org> In-Reply-To: From: Ed Maste Date: Wed, 25 Sep 2019 19:01:21 -0400 Message-ID: Subject: Re: svn commit: r352661 - head/sys/netinet/tcp_stacks To: Dimitry Andric Cc: Bruce Evans , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46dtpm5Flvz4gQf X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Sep 2019 23:01:37 -0000 On Wed, 25 Sep 2019 at 17:13, Dimitry Andric wrote: > > > Interesting, it seems Clang doesn't even warn in the case of casting a > > uint64_t to a 32-bit pointer. Looks like there are some useful > > warnings that ought to be implemented. > > There is -Wconversion for this, or the more specific -Wshorten-64-to-32: But it's not all of -Wconversion I think we want or even 64- to 32-bit warnings, but particularly conversions between pointers and integers of different sizes.