From nobody Wed Oct 11 02:44:42 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S4xvH2WWJz4wk3G; Wed, 11 Oct 2023 02:44:59 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S4xvH1tNPz4gLB; Wed, 11 Oct 2023 02:44:59 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696992299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LxiCc4yj5xk4WDe1Ii1wyTAH5kE0DBegTmF0KvOvU78=; b=k/c1rqmZMVLopkwcEwa/Wi0oR/nmsVvEvjQoZJAJ+sqnYnnV7la/JhV/GqimiiOFAwsZh9 NjdMlZT25/3SWoBG2f6mEVeyiJqfdVginlwuGIyB5uvxlOgVWd89OdkG1lWQfSeRvZrfJt s7+m7EVi5qZyFNEyMarDM9ALGazfma1wo7TLy0gDjQr3TcJgfs+qghpRa/7p84OZqnzXpw j+7pKLPbYGc004svfG9s7De4xCr6YNT2VsCYkq4J1ZXsrfN4WKlnXnhgbYJtVNQ9PdfXn6 bBJqdbtpC38ezEC/QeFYEupW6T/cmlfC/OizmvNcDy6iW1gKSLzelaRN2B05Og== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696992299; a=rsa-sha256; cv=none; b=IRbNUyRWLEYsItH5DAGoRKBw+mdomy+QlbobZ38juFT8Vh8pXXd2yGNaelDaufnYAIdt5K xlH7tQz+wa/OYz2D9gso7IvXz8By6F8wy6hCjluy98Elq/tX9MslCoODNB8qA+edXGDStW fwmcOcY23oktZkPh7uY1kxXLedbqCzoN17dOxUrOo5W92w8KEBgAKCvnG8foYsFDr9aH5F FAfdvi5iJ/pRuJbndgkgGvJDUa6U7ykgXvwM0b9tMgMOtXPjs+8lYNO6c1YUrWEDGM82nf Rv4IbKrYISSYPTlsMU10RubiT5b/MLi9cS5NJ4uU2uFVUy3ICo4k6BBfGUDpYw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696992299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LxiCc4yj5xk4WDe1Ii1wyTAH5kE0DBegTmF0KvOvU78=; b=bsNL/KwitwJPxNn+3EG18BpT08pSmE2COYh/zVzBUUuRBo5g8tCWhRWHCh0Ap6tZ3IUn3E c34UIlDsQ4UpRuU1lkFBNB6RaC/TfEUOE1zHHOqklH3i4iiFCcH4RoxZs/uBQH7+26vGt+ nw8ZZz7G5P0Be54cNlueaKkGa9bpDmzofET2t0HtmzrzeFSzuxPK7xNNfe+fExPZj29X2V 1rkSnU5neFpQwGJ6XP6DiSBYWVSqySBx0SpDwiX2d8ArtCKi/ybadVxpQlkYirl72mdl09 IbufDythzuoMmnA5wdLuav7G1IusqyOUiVjW3tp6O54ONB3C8UJI3n6iqSmR7w== Received: from [192.168.0.120] (unknown [103.49.53.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 4S4xvD6J7Bz1Pdr; Wed, 11 Oct 2023 02:44:56 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.77.23091703 Date: Wed, 11 Oct 2023 08:14:42 +0530 Subject: Re: 26103ccba8b7 - main - zfs: enable block cloning by default From: Ravi Pokala To: Martin Matuska , , , Message-ID: <2D247230-D189-4A43-85A2-0F2442A9CA6A@panasas.com> Thread-Topic: 26103ccba8b7 - main - zfs: enable block cloning by default References: <202310102247.39AMlsjX018898@gitrepo.freebsd.org> In-Reply-To: <202310102247.39AMlsjX018898@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable Hi Martin, The commit message says "what", not "why". Why was block cloning disabled by default before, and why is it being enabl= ed now? Thanks, Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: > on behalf of Martin Matuska > Date: Wednesday, October 11, 2023 at 04:17 To: >, >, > Subject: git: 26103ccba8b7 - main - zfs: enable block cloning by default The branch main has been updated by mm: URL: https://cgit.FreeBSD.org/src/commit/?id=3D26103ccba8b75038bd83773268524a= c814bfa334 commit 26103ccba8b75038bd83773268524ac814bfa334 Author: Martin Matuska > AuthorDate: 2023-10-10 22:43:35 +0000 Commit: Martin Matuska > CommitDate: 2023-10-10 22:43:35 +0000 zfs: enable block cloning by default Discussed with: markj Reviewed by: mav Tested by: mm (FreeBSD test suite + OpenZFS test suite) MFC after: 2 months Differential Revision: https://reviews.freebsd.org/D41991 --- sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c b/sys/c= ontrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c index 8969fd6a54bd..09e18de81748 100644 --- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c +++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c @@ -89,7 +89,7 @@ int zfs_debug_level; SYSCTL_INT(_vfs_zfs, OID_AUTO, debug, CTLFLAG_RWTUN, &zfs_debug_level, 0, "Debug level"); -int zfs_bclone_enabled; +int zfs_bclone_enabled =3D 1; SYSCTL_INT(_vfs_zfs, OID_AUTO, bclone_enabled, CTLFLAG_RWTUN, &zfs_bclone_enabled, 0, "Enable block cloning");