From owner-svn-src-all@freebsd.org Wed May 22 15:55:30 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0357E15AFC54 for ; Wed, 22 May 2019 15:55:30 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6DC668C675 for ; Wed, 22 May 2019 15:55:29 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1558540520; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=NTYcUTi/hpek4IB90tIo/m8+cqTaGKM8p2K6va2XL7+ywPQUXtfQhBeEYcfJ30WPEl65vOjMhLukQ U4vEX+FCHd7c1lP5bA0Fi8brz/s+60EwJ/WkaM15n8bXVkQKvtdEsDQnrfOcJiT5LsZc8HAMnS+Frp O0wDr5lIdzmPYcbDOmqOEWUKr1X+0JXjAqW2H7pgPKWJMAdJ0hVsBBohjKrMMJU2TYIODim76RGCfe Vq3AGkjTBlDAfHTjqVyLUoCgjfbq7BzCARRTkcEFDA42baBufXkHsH/aAbY5Qd3V2LRNSY+TjeGkBS CjeoqdTH9vDne9uy5Z6LNVwM1ckX68w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=gKnsbhQkIvCxNclI2m/oiLWsOQpjYVU2uFH0D1rHf3Y=; b=SP5Vv8OOQ8IH6NmiaZ5JcaAm8spMlfvmSe+BbbRcTINC5zl92VNv9nsr/yTCErVcy8PR509fliiWL EQEy3L7U+tCHGVD8JqOsilqpm4NcBEP5+MdKZDx2zr6e+AR6cV/P3Pj/YCOPXKo2P3YCvZnWO5SCUK SZDjtJDxkuzuZ0nx1eWSvMvKGqPvygASwxhS+xOCtmMnxMuKlZlWxzPr60kwGV0nZK4LHGjthtR0Ol LiGxJ4s5QwsdN0181eVWgkNTDf3QOppV7VCExiFOradGNmsMWBGwS9Q6ptTkUH5fAwXfecV4gN6NxI NQW1Lfu9m77pv9p5+y2ZY9YiNMXaEgw== ARC-Authentication-Results: i=1; outbound2.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=gKnsbhQkIvCxNclI2m/oiLWsOQpjYVU2uFH0D1rHf3Y=; b=ozWtREdY3fV6K13Z1tYu6y74HOFDZSbMdROSCeOmEru6oO3dfHyf/aiPfiwLH+T2KmVOPevwgsBwK jLin/OXYLyui1g/Gwhl2RpZUQxfZ0UjhelY7m69FzSayw68YFCim5F9h904Z0xqLil3wMwM7lyY5nC hTIqqFPqkV1xhYlBtiS79RKm8oBhYT4TRkXdFdnYihoXh+Y6ZVH+z9GT8UhHHGwMaUcun3NDNKiXI6 xEzt0lA2FS+dteRVjARU0TBNMdH4Iwv7GPJ1Z2+DSc1cdbyReKF6+IMcy9zWKWur7v5I2K4CUmamOR VsmALaULWn3wxknjNDcP0J8ITb5yj+Q== X-MHO-RoutePath: aGlwcGll X-MHO-User: fd796119-7ca9-11e9-85c6-c97e5c048ed3 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.eu.mailhop.org (Halon) with ESMTPSA id fd796119-7ca9-11e9-85c6-c97e5c048ed3; Wed, 22 May 2019 15:55:17 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x4MFtFZ3006056; Wed, 22 May 2019 09:55:15 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1d047fa8535df8688a21d17b3a869182df62c942.camel@freebsd.org> Subject: Re: svn commit: r348090 - in head/libexec/bootpd: . bootpgw From: Ian Lepore To: rgrimes@freebsd.org, Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 22 May 2019 09:55:15 -0600 In-Reply-To: <201905221548.x4MFmAIF085473@gndrsh.dnsmgr.net> References: <201905221548.x4MFmAIF085473@gndrsh.dnsmgr.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6DC668C675 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.985,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 15:55:30 -0000 On Wed, 2019-05-22 at 08:48 -0700, Rodney W. Grimes wrote: > > On Tue, May 21, 2019 at 09:25:23PM -0700, Rodney W. Grimes wrote: > > > > Author: markj > > > > Date: Wed May 22 04:13:57 2019 > > > > New Revision: 348090 > > > > URL: https://svnweb.freebsd.org/changeset/base/348090 > > > > > > > > Log: > > > > Marginally improve usage() message style in bootpd. > > > > > > > > - Remove an extra space after "usage:". > > > > - Avoid lines exceeding 80 columns. > > > > > > > > Based on notes from rgrimes. > > > > > > Thanks, but you missed an important aspect of those notes, > > > see inline below. > > > > > > > > > > > MFC with: r348066 > > > > Event: Waterloo Hackathon 2019 > > > > > > > > Modified: > > > > head/libexec/bootpd/bootpd.c > > > > head/libexec/bootpd/bootpgw/bootpgw.c > > > > > > > > Modified: head/libexec/bootpd/bootpd.c > > > > =============================================================== > > > > =============== > > > > --- head/libexec/bootpd/bootpd.c Wed May 22 04:10:24 > > > > 2019 (r348089) > > > > +++ head/libexec/bootpd/bootpd.c Wed May 22 04:13:57 > > > > 2019 (r348090) > > > > @@ -587,8 +587,8 @@ PRIVATE void > > > > usage() > > > > { > > > > fprintf(stderr, > > > > - "usage: bootpd [-a] [-i | -s] [-c > > > > chdir-path] [-d level] [-h hostname] [-t timeout]\n"); > > > > - fprintf(stderr, " [bootptab > > > > [dumpfile]]\n"); > > > > + "usage: bootpd [-a] [-i | -s] [-c chdir-path] > > > > [-d level] [-h hostname]\n" > > > > + " [-t timeout] [bootptab > > > > [dumpfile]]\n"); > > > > fprintf(stderr, "\t -a\tdon't modify ARP table\n"); > > > > fprintf(stderr, "\t -c n\tset current directory\n"); > > > > fprintf(stderr, "\t -d n\tset debug level\n"); > > > > > > These 3 printf's are now miss aligned and contain a \t that > > > should not be there: > > > there may be more, I am only look at what is in context here. > > > - fprintf(stderr, "\t -a\tdon't modify ARP table\n"); > > > - fprintf(stderr, "\t -c n\tset current directory\n"); > > > - fprintf(stderr, "\t -d n\tset debug level\n"); > > > + fprintf(stderr, " -a\tdon't modify ARP table\n"); > > > + fprintf(stderr, " -c n\tset current > > > directory\n"); > > > + fprintf(stderr, " -d n\tset debug level\n"); > > > > They were seemingly misaligned before too. > > > > Before: > > usage: bootpd [-i | -s] [-c chdir-path] [-d level] [-h hostname] > > [-t timeout] > > [bootptab [dumpfile]] > > -c n set current directory > > -d n set debug level > > -h n set the hostname to listen on > > -i force inetd mode (run as child of inetd) > > -s force standalone mode (run without inetd) > > -t n set inetd exit timeout to n minutes > > > > After: > > usage: bootpd [-a] [-i | -s] [-c chdir-path] [-d level] [-h > > hostname] > > [-t timeout] [bootptab [dumpfile]] > > -a don't modify ARP table > > -c n set current directory > > -d n set debug level > > -h n set the hostname to listen on > > -i force inetd mode (run as child of inetd) > > -s force standalone mode (run without inetd) > > -t n set inetd exit timeout to n minutes > > > > To be honest I have no desire to spend more time on bootpd than I > > already have. You are welcome to improve the usage formatting if > > you like. > > omg, really? Old "folke lore" You touched, you own it. > > If I didnt have to go through bde and/or phk I would of just gone > and commited the clean up. I have handed you the diff. > > Perhaps a phab review before would of made this less painfull. > And perhaps a phab review once an issue had been raised would > of been really less painful. > Or perhaps trying to browbeat someone into doing extensive changes when all they intended to do was a simple obvious thing is asking too much. You seem to expend quite a bit of energy in making perfect the enemy of better. The long term result of that is that either people will just habitually ignore your feedback, or they'll stop doing simple things to make the world better because they're tired of being told their work achieves less than perfection. -- Ian