From owner-freebsd-multimedia@FreeBSD.ORG Fri Jul 13 05:12:05 2007 Return-Path: X-Original-To: multimedia@freebsd.org Delivered-To: freebsd-multimedia@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AB12816A401 for ; Fri, 13 Jul 2007 05:12:05 +0000 (UTC) (envelope-from loafier@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.251]) by mx1.freebsd.org (Postfix) with ESMTP id 641F713C48D for ; Fri, 13 Jul 2007 05:12:05 +0000 (UTC) (envelope-from loafier@gmail.com) Received: by an-out-0708.google.com with SMTP id c14so97407anc for ; Thu, 12 Jul 2007 22:12:04 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=SF9+96LqvEg+9itKEp06tKFC+SCyV16HCAR67Ma/V0mG0BYSjIudop2TAmxxMM5fIn6j1wTdy04iLmzbsZvV2tswUOpnCRV8pxaCwuDB1yqalLEloa2Ls54kHRj2WbIHWktvRzQCxBrI1bcIgy7Pf//QS0A4Oeh9Jt7H4RlTqlc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=X0L8yQ4b6VXZMZdqtG2F66MYuEd/MptyKMDJ1oCirAvuGdpzPslbP+OjCL5G9M7q8A3B+jJa3o+DXmgxuSqIDUVYSrr6TC3VLvb/Q/5fWwLuUd30YHqwb7R577ebfbs3/y9aYLQdneJFZAOuvKJKwL1GRae34uhvH8/+zeQkYak= Received: by 10.100.191.5 with SMTP id o5mr765959anf.1184303524221; Thu, 12 Jul 2007 22:12:04 -0700 (PDT) Received: by 10.100.109.17 with HTTP; Thu, 12 Jul 2007 22:12:04 -0700 (PDT) Message-ID: Date: Thu, 12 Jul 2007 22:12:04 -0700 From: "Christopher Davis" Sender: loafier@gmail.com To: "Alexander Leidinger" In-Reply-To: <20070710093829.34mqbekao4wwww4s@webmail.leidinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070710093829.34mqbekao4wwww4s@webmail.leidinger.net> X-Google-Sender-Auth: 42e337e7d76d7bc5 Cc: freebsd-hackers@freebsd.org, Ariff@freebsd.org, multimedia@freebsd.org Subject: Re: Audio driver template X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2007 05:12:05 -0000 On 7/10/07, Alexander Leidinger wrote: > Putting it into the examples directory instead of having it on the > people's own pages would be an improvement (the developer handbook > needs to be changed to point to the examples directory then). > > And you should clarify what kind of improvements are valid for your > SoC work. Somehow I doubt that adding shiny new features (like hps > suggested) is part of the goal for your work. I think it's more like > bringing existing drivers up-to-par with currently available generic > driver interfaces, isn't it? > > I also think examples for suspend/resume stuff should be added. > /sys/dev/sound/pci/atiixp.c has suspend and resume methods if you want > an example. > > You could also review the locking, as it changed a little bit > recently, I think. > > Apart from the atiixp driver the envy42, emu10kx and HDA drivers can > also serve as examples for what is the most current in the sound > subsystem in FreeBSD. Maybe you can gain some more hints from them (I > think the template is not very up-to-date compared to them). > > The new mixer interface is not used yet in the drivers, so we don't > have examples at all for them. You could ask ryanb@FreeBSD.org (or on > multimedia@) about it. > > Ariff@FreeBSD.org (or multimedia@) can maybe help if you have some > questions regarding the drivers in the tree (maybe Ariff will answer > to your initial question anyway). > > Bye, > Alexander. > > -- > I guess the Little League is even littler than we thought. > -- D. Cavett > > http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 > http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 > Made another update: http://loafier.sixbit.org/template.c - removed wierd garbage characters around the initcd function - made names of read and write macros consistent w/ other functions - fixed invocation of snd_mtxcreate() to include name string I also copied in some code from the atiixp drivers's suspend/resume functions for handling the play and record channels, and noticed the use of pci_set_powerstate(). -- Christopher Davis