From owner-freebsd-rc@FreeBSD.ORG Tue Mar 29 03:24:38 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93909106566C; Tue, 29 Mar 2011 03:24:38 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.vlsi.ee.noda.tus.ac.jp (sekine00.ee.noda.sut.ac.jp [133.31.107.40]) by mx1.freebsd.org (Postfix) with ESMTP id 1F6388FC12; Tue, 29 Mar 2011 03:24:37 +0000 (UTC) Received: from alph.allbsd.org (p2237-ipbf904funabasi.chiba.ocn.ne.jp [122.26.37.237]) (user=hrs mech=DIGEST-MD5 bits=128) by mail.vlsi.ee.noda.tus.ac.jp (8.14.4/8.14.3) with ESMTP id p2T2xTYT084854 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 29 Mar 2011 11:59:39 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.allbsd.org (8.14.4/8.14.4) with ESMTP id p2T2xMKs012486; Tue, 29 Mar 2011 11:59:23 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Tue, 29 Mar 2011 11:59:00 +0900 (JST) Message-Id: <20110329.115900.969026047405273902.hrs@allbsd.org> To: wxs@FreeBSD.org From: Hiroki Sato In-Reply-To: <20110329024441.GA24720@atarininja.org> References: <20110319012959.GA39929@atarininja.org> <20110319013155.GB39929@atarininja.org> <20110329024441.GA24720@atarininja.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Tue_Mar_29_11_59_00_2011_653)--" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.5 (mail.vlsi.ee.noda.tus.ac.jp [133.31.107.40]); Tue, 29 Mar 2011 11:59:40 +0900 (JST) X-Spam-Status: No, score=6.1 required=14.0 tests=BAYES_50, CONTENT_TYPE_PRESENT, RCVD_IN_PBL, RCVD_IN_RP_RNBL, SPF_SOFTFAIL, X_MAILER_PRESENT autolearn=no version=3.3.1 X-Spam-Level: ****** X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.vlsi.ee.noda.tus.ac.jp Cc: freebsd-rc@FreeBSD.org Subject: Re: status cleanup X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2011 03:24:38 -0000 ----Security_Multipart(Tue_Mar_29_11_59_00_2011_653)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Wesley Shields wrote in <20110329024441.GA24720@atarininja.org>: wx> On Fri, Mar 18, 2011 at 09:31:55PM -0400, Wesley Shields wrote: wx> > On Fri, Mar 18, 2011 at 09:29:59PM -0400, Wesley Shields wrote: wx> > > A co-worker noticed that the pf rc script has 'status' listed twice when wx> > > run without any arguments. The attached patch fixes that and two other wx> > > cases where this also happens. I've only tested the pf changes. I'd wx> > > appreciate a review of this and maybe a commit? I can file a PR if it wx> > > would make people feel better. wx> > > wx> > > I'm not subscribed to this list so I would appreciate being CC'ed on any wx> > > replies. wx> > > wx> > > -- WXS wx> > wx> > This time with the patch attached, or you can get it at: wx> > wx> > http://people.freebsd.org/~wxs/rc-status-cleanup.diff wx> > -extra_commands="status prefer_ipv6 prefer_ipv4" wx> > +extra_commands="prefer_ipv6 prefer_ipv4" For the ip6addrctl script removing "status" is wrong. This keyword is automatically added only when ${name}_program is defined and the ip6addrctl does not define it. The other two changes look good to me. If there is no objection in a day or two, I will commit them. Thank you for your report. -- Hiroki ----Security_Multipart(Tue_Mar_29_11_59_00_2011_653)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk2RSvQACgkQTyzT2CeTzy2GCgCgykuFfNatnnx6bvlXkG15Uudm iEoAoIpfZ34trbbTYD3PzSqK4P7Ch4gD =NilL -----END PGP SIGNATURE----- ----Security_Multipart(Tue_Mar_29_11_59_00_2011_653)----