From owner-freebsd-ports@freebsd.org Thu Oct 1 21:12:00 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 045AF434337 for ; Thu, 1 Oct 2020 21:12:00 +0000 (UTC) (envelope-from moritz@schmi.tt) Received: from serving.schmi.tt (serving.schmi.tt [IPv6:2001:67c:1400:22a0::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4C2Qmb0tnVz3T85 for ; Thu, 1 Oct 2020 21:11:58 +0000 (UTC) (envelope-from moritz@schmi.tt) Received: from t470.schmi.tt (p5b2066a6.dip0.t-ipconnect.de [91.32.102.166]) by serving.schmi.tt (Postfix) with ESMTPSA id 941586F310 for ; Thu, 1 Oct 2020 23:12:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schmi.tt; s=serving; t=1601586765; r=y; bh=WQBE/gLTArTpt4LJ4QccpKbIZsvRxerBGmwMyyJxjHs=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: User-Agent; b=tpm3fnivmmDWG32IsO9G0T3RyLNlBua9hi+TpF5tnkhfzNa8qjWBfbd62Dh8Vr7gx 9JUbXK26fQYxKWv8Y+r6/Xjf3nmPhFNNFlmDN8yWSJVX8YqobVkrBdtRgr9D6oeGse /OJzBalx/2/bYfYvxn2TFpSHc/vtgG9tsNVaC8rKdCMU2qC0jmTfyxFtW8fDfFmU1Q BEFRTduBBRP2ZQVWgnk649eCtQSPezoNF4Ur4JIGcPV+MZAeX5akUNKDDYUtR/50rC t2nIl0revduB9aIdI0lByxtoM81nz7qLI2occI4DR7vBVYBrJMMzJrfG2zpmCVHzpq /oQvqns5nXixA== Date: Thu, 1 Oct 2020 23:11:49 +0200 From: Moritz Schmitt To: freebsd-ports@freebsd.org Subject: Patch compiler warnings away? Message-ID: <20201001211149.uhdi4w6xstjv4iw3@t470.schmi.tt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 4C2Qmb0tnVz3T85 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=schmi.tt header.s=serving header.b=tpm3fniv; dmarc=pass (policy=none) header.from=schmi.tt; spf=pass (mx1.freebsd.org: domain of moritz@schmi.tt designates 2001:67c:1400:22a0::1 as permitted sender) smtp.mailfrom=moritz@schmi.tt X-Spamd-Result: default: False [-2.53 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[schmi.tt:s=serving]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.97)[-0.972]; NEURAL_HAM_MEDIUM(-1.03)[-1.032]; DKIM_TRACE(0.00)[schmi.tt:+]; DMARC_POLICY_ALLOW(-0.50)[schmi.tt,none]; NEURAL_HAM_SHORT(-0.53)[-0.531]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:29670, ipnet:2001:67c:1400::/45, country:DE]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-ports]; RECEIVED_SPAMHAUS_PBL(0.00)[91.32.102.166:received] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 21:12:00 -0000 Hi, I recently took over my first maintainership of a port and I have a question regarding on how to deal with compiler warnings. The port is devel/cscope and it seems to be in a rather good shape. It contains the newest version of cscope and it builds without any major problems. However, when building it the compiler issues three warnings that I could easily patch away. What's the recommended approach? Just ignore the warnings and don't modify the software since it builds anyway? Or create patches even though they don't seem to be strictly necessary? In any case, I will send the patches to the project in the hope that they fix it upstream in the long run. Best, Moritz