From owner-freebsd-bugs@FreeBSD.ORG Fri Jan 17 03:40:24 2014 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6C5BF4AE; Fri, 17 Jan 2014 03:40:24 +0000 (UTC) Received: from mail-pd0-x232.google.com (mail-pd0-x232.google.com [IPv6:2607:f8b0:400e:c02::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 368A217C7; Fri, 17 Jan 2014 03:40:24 +0000 (UTC) Received: by mail-pd0-f178.google.com with SMTP id y13so3468339pdi.9 for ; Thu, 16 Jan 2014 19:40:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:message-id:mime-version:subject:date:references :to:in-reply-to; bh=xQe9Sf834DkLiyqMo42KCrY97AddYsIJeORREe6dixA=; b=m5/BVfx5fyvDXOFOAzkmQb9YpNzCReVy3sOGJtFjiat2ZxkoRCp8XqCWwRtXuufA4v A+J089AsiJY9M3f8ziH+RoS5Fi+G0gA5gq1zrxvykZAQsjzH1PPZ/5M7I8dqn7Tt1o4R ksKpyit+rTxD1oaLOYkRv0P1Gy9PhNTNKo5qWFEPSK9s24Ip9uS0llwsEBUj9CuYKfi5 bVrrk6Pg9Vwlfsw2FxLkREj6PEwxp6hQytUNib25viEeAYDmKc3Inauw3RdQ7hbCBEQx XWRhAf3fiEe0mS26htdWO+EK5orsGlLbSZ0N6DDqvozc4OKqgWQ+X2lDnXc90CaRJP+L 7P5Q== X-Received: by 10.68.212.10 with SMTP id ng10mr14224604pbc.95.1389930023808; Thu, 16 Jan 2014 19:40:23 -0800 (PST) Received: from [192.168.20.5] (c-50-181-163-89.hsd1.wa.comcast.net. [50.181.163.89]) by mx.google.com with ESMTPSA id g6sm25295667pat.2.2014.01.16.19.40.21 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 16 Jan 2014 19:40:22 -0800 (PST) From: Garrett Cooper Content-Type: multipart/mixed; boundary="Apple-Mail=_3E02B388-8DD9-411B-AFF7-1ECBB3FD872E" Message-Id: Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: bin/185648: fmtree is unnecessarily noisy Date: Thu, 16 Jan 2014 19:40:20 -0800 References: <201401102200.s0AM01qp093493@freefall.freebsd.org> To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org In-Reply-To: <201401102200.s0AM01qp093493@freefall.freebsd.org> X-Mailer: Apple Mail (2.1827) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jan 2014 03:40:24 -0000 --Apple-Mail=_3E02B388-8DD9-411B-AFF7-1ECBB3FD872E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Doing some code inspection, the noise is benign but not human = friendly. This patch should make it a little more human-friendly. Thanks, -Garrett --Apple-Mail=_3E02B388-8DD9-411B-AFF7-1ECBB3FD872E Content-Disposition: attachment; filename=0001-make-the-message-when-EEXIST-occurs-with-mkdir-2-mor.patch Content-Type: application/octet-stream; name="0001-make-the-message-when-EEXIST-occurs-with-mkdir-2-mor.patch" Content-Transfer-Encoding: quoted-printable =46rom=20a3e0cf67fab89883913fe516907ab0af7883164e=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Garrett=20Cooper=20=0A= Date:=20Mon,=2013=20Jan=202014=2009:48:27=20-0800=0ASubject:=20[PATCH]=20= make=20the=20message=20when=20EEXIST=20occurs=20with=20mkdir(2)=20more=0A= =20meaningful=0A=0A---=0A=20usr.sbin/mtree/verify.c=20|=207=20+++++--=0A=20= 1=20file=20changed,=205=20insertions(+),=202=20deletions(-)=0A=0Adiff=20= --git=20a/usr.sbin/mtree/verify.c=20b/usr.sbin/mtree/verify.c=0Aindex=20= b7c4fd9..f708846=20100644=0A---=20a/usr.sbin/mtree/verify.c=0A+++=20= b/usr.sbin/mtree/verify.c=0A@@=20-218,8=20+218,11=20@@=20miss(NODE=20*p,=20= char=20*tail)=0A=20=09=09=09}=20else=20if=20(!(p->flags=20&=20F_MODE))=0A= =20=09=09=09=20=20=20=20(void)printf("=20(directory=20not=20created:=20= mode=20not=20specified)");=0A=20=09=09=09else=20if=20(mkdir(path,=20= S_IRWXU))=0A-=09=09=09=09(void)printf("=20(directory=20not=20created:=20= %s)",=0A-=09=09=09=09=20=20=20=20strerror(errno));=0A+=09=09=09=09if=20= (errno=20=3D=3D=20EEXIST)=0A+=09=09=09=09=09(void)printf("=20(path=20= already=20exists)");=0A+=09=09=09=09else=0A+=09=09=09=09=09= (void)printf("=20(directory=20not=20created:=20%s)",=0A+=09=09=09=09=09=20= =20=20=20strerror(errno));=0A=20=09=09=09else=20{=0A=20=09=09=09=09= create=20=3D=201;=0A=20=09=09=09=09(void)printf("=20(created)");=0A--=20=0A= 1.8.4.1=0A=0A= --Apple-Mail=_3E02B388-8DD9-411B-AFF7-1ECBB3FD872E--