From owner-freebsd-current  Sat Sep 28  8:45:55 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 717B637B401
	for <current@freebsd.org>; Sat, 28 Sep 2002 08:45:54 -0700 (PDT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B2A7C43E6A
	for <current@freebsd.org>; Sat, 28 Sep 2002 08:45:53 -0700 (PDT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id g8SFjZ0U031993
	for <current@freebsd.org>; Sat, 28 Sep 2002 17:45:35 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: current@freebsd.org
Subject: kern_sig.c mis-indentation
From: Poul-Henning Kamp <phk@freebsd.org>
Date: Sat, 28 Sep 2002 17:45:35 +0200
Message-ID: <31992.1033227935@critter.freebsd.dk>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG


The indentation and the braces look rather odd in this bit of
kern_sig.c, somebody should straighten it up and check if
there are any bugs in this:

                              mi_switch();
                                mtx_unlock_spin(&sched_lock);
                                PICKUP_GIANT();
                                PROC_LOCK(p);
                                break;
                        } else
                             if (prop & SA_IGNORE) {
                                /*
                                 * Except for SIGCONT, shouldn't get here. 
                                 * Default action is to ignore; drop it.
                                 */
                                break;          /* == ignore */
                        } else
                                return (sig);
                        /*NOTREACHED*/
 

Poul-Henning

PS: Yes, another score by FlexeLint!

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message