From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jul 2 00:11:59 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 52E0116A4CF for ; Fri, 2 Jul 2004 00:11:59 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A97943D49 for ; Fri, 2 Jul 2004 00:11:59 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i620AS69025683 for ; Fri, 2 Jul 2004 00:10:28 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i620ASTo025682; Fri, 2 Jul 2004 00:10:28 GMT (envelope-from gnats) Date: Fri, 2 Jul 2004 00:10:28 GMT Message-Id: <200407020010.i620ASTo025682@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Per Hedeland Subject: Re: ports/68532: Add support for multiple VMWare instances X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Per Hedeland List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2004 00:11:59 -0000 The following reply was made to PR ports/68532; it has been noted by GNATS. From: Per Hedeland To: FreeBSD-gnats-submit@FreeBSD.org Cc: orlando.bassotto@ieo-research.it Subject: Re: ports/68532: Add support for multiple VMWare instances Date: Fri, 2 Jul 2004 02:04:11 +0200 (CEST) Addendum regarding the "removed setting of IP address on vmnet devices that are in a bridge": With some more experimenting, I found that the requirement for this to work isn't actually the OS version, but the fact that you use "Custom" + "/dev/vmnetN" in the VMWare ethernet config. If you leave it at "Host Only" for vmnet1, VMWare (the binary) requires that an IP address is configured. Since this will be very confusing for a user that doesn't care about the possibility of having multiple instances, but just sets up a single, bridged one via the default port build/install, the VMNET_ADDR_ON_BRIDGED_INTERFACE=NO setting is a bad idea. The patches below (to be applied on top of the others) revert the default to the previous behaviour, and allow for the "no IP address" in a different way: If the config file specifies 0.0.0.0 as the HostOnlyAddress for a bridged interface, it will end up without an IP address configured. --Per Hedeland per@hedeland.org --- /usr/ports/emulators/vmware3/Makefile.ORIG Thu Jul 1 17:49:51 2004 +++ /usr/ports/emulators/vmware3/Makefile Thu Jul 1 21:18:00 2004 @@ -68,8 +68,6 @@ VMNET1_MINOR= 0x00800001 .endif -VMNET_ADDR_ON_BRIDGED_INTERFACE= NO - SCRIPTS_ENV+= LINUXBASE="${LINUXBASE}" \ VMNET_HOST_IP="${VMNET_HOST_IP}" \ VMNET_NETMASK="${VMNET_NETMASK}" \ @@ -145,7 +143,6 @@ ${SED} -e 's;@@PREFIX@@;${PREFIX};' \ -e 's;@@LINUXBASE@@;${LINUXBASE};' \ -e 's;@@NETWORKING@@;${VMNET_NETWORKING};' \ - -e 's;@@ADDR_BRIDGE_IF@@;${VMNET_ADDR_ON_BRIDGED_INTERFACE};' \ ${FILESDIR}/001.vmware.sh > ${WRKDIR}/001.vmware.sh ${SED} -e 's;@@PREFIX@@;${PREFIX};' \ --- /usr/ports/emulators/vmware3/files/001.vmware.sh.ORIG Thu Jul 1 17:49:51 2004 +++ /usr/ports/emulators/vmware3/files/001.vmware.sh Thu Jul 1 21:17:59 2004 @@ -24,7 +24,6 @@ vmware=`vmware_config vmware.fullpath` vmware_libdir=`vmware_config libdir` networking=@@NETWORKING@@ -addr_on_bridge_if=@@ADDR_BRIDGE_IF@@ dev_vmnet1=/dev/vmnet1 if [ ! -x $vmware ]; then @@ -65,7 +64,7 @@ echo -n > /dev/$vmnet 2>&1 ifconfig $vmnet $host_ip netmask $netmask if [ X$bridged = XYES ]; then - if [ X$addr_on_bridge_if = XNO ]; then + if [ X$host_ip = X0.0.0.0 ]; then # XXX Still need to configure + delete to make it RUNNING ifconfig $vmnet delete $host_ip fi @@ -111,7 +110,7 @@ host_ip=`vmware_config $vmnet.HostOnlyAddress` ifconfig $vmnet down if [ X$bridged = XYES ]; then - if [ X$addr_on_bridge_if = XYES ]; then + if [ X$host_ip != X0.0.0.0 ]; then ifconfig $vmnet delete $host_ip fi bridge_interface=`vmware_config $vmnet.BridgeInterface`